Issue 1148503003: Revert of Remember previous keyboard type and use that when switching to "none" type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1148503003: Revert of Remember previous keyboard type and use that when switching to "none" type. (Closed)

Created:
5 years, 7 months ago by aelias_OOO_until_Jul13

Modified:
5 years, 7 months ago

Reviewers:
bcwhite, aurimas (slooooooooow)

CC:
chromium-reviews, darin-cc_chromium.org, jam, yosin_UTC9, Yuta Kitamura

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Remember previous keyboard type and use that when switching to "none" type. (patchset #2 id:20001 of https://codereview.chromium.org/1138103003/) Reason for revert: Patch landed despite rejection from code reviewers. Original issue's description: > Remember previous keyboard type and use that when switching to "none" type. > > BUG=484139 > > Committed: https://crrev.com/e8e5d60be5f3b36634a1b012ec21874a4abe0ef0 > Cr-Commit-Position: refs/heads/master@{#330551} TBR=aurimas@chromium.org,bcwhite@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484139 Committed: https://crrev.com/e960671575c99b0a3fe3e594d4007c79d56824bc Cr-Commit-Position: refs/heads/master@{#330625}

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -16 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java	View		3 chunks	+1 line, -16 lines	0 comments	Download

Total messages: 4 (0 generated)

aelias_OOO_until_Jul13

Created Revert of Remember previous keyboard type and use that when switching to "none" type.

5 years, 7 months ago (2015-05-19 21:58:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148503003/1

5 years, 7 months ago (2015-05-19 21:59:38 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-19 22:02:21 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e960671575c99b0a3fe3e594d4007c79d56824bc
Cr-Commit-Position: refs/heads/master@{#330625}