ninja: Add a friendlier error message if no prebuilt binary is found.

ninja: Add a friendlier error message if no prebuilt binary is found.

See https://bugs.webkit.org/show_bug.cgi?id=104523

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=172427

[eseidel, 2012-12-10 19:56:05]

Looks great to me.

[M-A Ruel, 2012-12-10 19:57:32]

Please coordinate with Tony; https://codereview.chromium.org/11511007/

[Nico, 2012-12-10 20:16:34]

Ok, sounds we need a 32bit binary for 32bit bots anyway :-(

But adding this note for non-linux platforms is probably nice anyhow. I'll wait
for Tony's CL to land and then I'll rebase this.

[Lei Zhang, 2012-12-10 20:34:45]

Let's wait for tony's CL to land and go from there.

https://codereview.chromium.org/11485007/diff/4001/ninja
File ninja (right):

https://codereview.chromium.org/11485007/diff/4001/ninja#newcode11
ninja:11: echo "No prebuilt ninja binary was found for this system."
you can also:

cat << __EOF
here is
my
message
__EOF

[Nico, 2012-12-11 04:49:34]

Rebased.

https://codereview.chromium.org/11485007/diff/4001/ninja
File ninja (right):

https://codereview.chromium.org/11485007/diff/4001/ninja#newcode11
ninja:11: echo "No prebuilt ninja binary was found for this system."
On 2012/12/10 20:34:45, Lei Zhang wrote:
> you can also:
> 
> cat << __EOF
> here is
> my
> message
> __EOF

Done.

[Lei Zhang, 2012-12-11 05:59:16]

lgtm

[M-A Ruel, 2012-12-11 14:24:55]

https://codereview.chromium.org/11485007/diff/7002/ninja
File ninja (right):

https://codereview.chromium.org/11485007/diff/7002/ninja#newcode11
ninja:11: cat << EOF
In theory you'd want this line to be indented.

https://codereview.chromium.org/11485007/diff/7002/ninja#newcode15
ninja:15: git clone https://github.com/martine/ninja.git
git clone https://github.com/martine/ninja.git -b v1.0.0

https://codereview.chromium.org/11485007/diff/7002/ninja#newcode16
ninja:16: cd ninja
Does ./ninja/bootstrap.py works? If so, you'd save another command line.

[Nico, 2012-12-11 18:36:54]

https://codereview.chromium.org/11485007/diff/7002/ninja
File ninja (right):

https://codereview.chromium.org/11485007/diff/7002/ninja#newcode11
ninja:11: cat << EOF
On 2012/12/11 14:24:55, Marc-Antoine Ruel wrote:
> In theory you'd want this line to be indented.

I could use <<- for a here document that strips leading indent, but that only
works with tab indent. I think it's better as is?

https://codereview.chromium.org/11485007/diff/7002/ninja#newcode15
ninja:15: git clone https://github.com/martine/ninja.git
On 2012/12/11 14:24:55, Marc-Antoine Ruel wrote:
> git clone https://github.com/martine/ninja.git -b v1.0.0

Done.

https://codereview.chromium.org/11485007/diff/7002/ninja#newcode16
ninja:16: cd ninja
On 2012/12/11 14:24:55, Marc-Antoine Ruel wrote:
> Does ./ninja/bootstrap.py works? If so, you'd save another command line.

Done.

[M-A Ruel, 2012-12-11 18:45:06]

lgtm

https://codereview.chromium.org/11485007/diff/13002/ninja
File ninja (right):

https://codereview.chromium.org/11485007/diff/13002/ninja#newcode11
ninja:11: cat <<-EOF
I only meant to have "  cat << EOF" and the rest not indented. I don't mind
much.

[commit-bot: I haz the power, 2012-12-11 22:13:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/11485007/19001

[commit-bot: I haz the power, 2012-12-11 22:15:42]

Change committed as 172427