tools/clang/scripts/update.sh - Issue 1148483002: Clang update.sh: fix logical or-expression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/scripts/update.sh

Issue 1148483002: Clang update.sh: fix logical or-expression (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/scripts/update.sh

diff --git a/tools/clang/scripts/update.sh b/tools/clang/scripts/update.sh

index 302d7cea6d091fcbccf4660f2fbefd479dca008e..adcd64c1cc4a76c0c151e966914bc41f5d831a91 100755

--- a/tools/clang/scripts/update.sh

+++ b/tools/clang/scripts/update.sh

@@ -698,7 +698,7 @@ if [[ -n "${with_android}" ]]; then

popd

-if [[ -n "$run_tests" -o -n ${LLVM_FORCE_HEAD_REVISION:-''} ]]; then

+if [[ -n "$run_tests" ]] || [[ -n "${LLVM_FORCE_HEAD_REVISION:-''}" ]]; then

Nico 2015/05/18 23:10:54 Doesn't || work inside of [[ ]] too? Do you need t

hans 2015/05/18 23:26:23 It works. Guess I should've gone for that from the

# Run Chrome tool tests.

ninja -C "${LLVM_BUILD_DIR}" cr-check-all

« no previous file with comments | « no previous file | no next file » | no next file with comments »