Clang update.sh: fix logical or-expression

Clang update.sh: fix logical or-expression

It seems Bash didn't like the -o variant:

+ [[ -n '' ]]
src/tools/clang/scripts/update.sh: line 701: syntax error in conditional expression

BUG=452726
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/7e7d24b956bc5bc1692030066b154d386eac780c

[hans, 2015-05-18 22:42:41]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2015-05-18 22:42:42]

This is a follow-up to https://codereview.chromium.org/1132123003/, which broke
things, e.g.
http://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/1489/s...
(though it seems buildbot ate the actual error message).

[Nico, 2015-05-18 23:10:54]

https://codereview.chromium.org/1148483002/diff/1/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/1148483002/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.sh:701: if [[ -n "$run_tests" ]] || [[ -n
"${LLVM_FORCE_HEAD_REVISION:-''}" ]]; then
Doesn't || work inside of [[ ]] too? Do you need to close and reopen the
brackets?

[hans, 2015-05-18 23:26:23]

Comments addressed.

https://codereview.chromium.org/1148483002/diff/1/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/1148483002/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.sh:701: if [[ -n "$run_tests" ]] || [[ -n
"${LLVM_FORCE_HEAD_REVISION:-''}" ]]; then
On 2015/05/18 23:10:54, Nico wrote:
> Doesn't || work inside of [[ ]] too? Do you need to close and reopen the
> brackets?

It works. Guess I should've gone for that from the beginning :-)

[Nico, 2015-05-18 23:36:10]

lgtm

(maybe -o is a [] thing, not a [[ ]] thing?)

[hans, 2015-05-18 23:37:50]

On 2015/05/18 23:36:10, Nico wrote:
> lgtm
> 
> (maybe -o is a [] thing, not a [[ ]] thing?)

Yeah, probably. And || is not a [] thing.

[hans, 2015-05-18 23:38:03]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2015-05-18 23:38:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148483002/20001

[commit-bot: I haz the power, 2015-05-18 23:41:03]

Patchset 2 (id:??) landed as
https://crrev.com/7e7d24b956bc5bc1692030066b154d386eac780c
Cr-Commit-Position: refs/heads/master@{#330451}

[hans, 2015-05-18 23:41:12]

Committed patchset #2 (id:20001) manually as
7e7d24b956bc5bc1692030066b154d386eac780c (presubmit successful).