Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 1148473002: Revert of Remove a HistoryNode's children when it navigates to a new document. (Closed)

Created:
5 years, 7 months ago by Charlie Reis
Modified:
5 years, 7 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove a HistoryNode's children when it navigates to a new document. (patchset #1 id:1 of https://codereview.chromium.org/1139033002/) Reason for revert: Caused a large spike in crashes across several bugs: https://crbug.com/426658 https://crbug.com/488382 https://crbug.com/488421 https://crbug.com/488434 https://crbug.com/488470 Original issue's description: > Remove a HistoryNode's children when it navigates to a new document. > > When a reload occurs (or other inert commits), we leave the history tree alone. However, if iframes are dynamically created, we end up with both the old iframes and the new iframes in the history tree, and we never prune them. Instead, if a different-document inert commit occurs, remove the committing node's children, since the corresponding frames are no longer in the frame tree. > > BUG=485385 > > Committed: https://crrev.com/9f3e29c910ce2c2a9c3a60b2675db59d95b8ad3a > Cr-Commit-Position: refs/heads/master@{#329763} TBR=japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=485385 Committed: https://crrev.com/5c8a902ebf5277d4c621d9c190cf659fbebcfc7a Cr-Commit-Position: refs/heads/master@{#330435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/renderer/history_controller.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Created Revert of Remove a HistoryNode's children when it navigates to a new document.
5 years, 7 months ago (2015-05-18 21:46:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148473002/1
5 years, 7 months ago (2015-05-18 21:47:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 21:49:46 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:44:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c8a902ebf5277d4c621d9c190cf659fbebcfc7a
Cr-Commit-Position: refs/heads/master@{#330435}

Powered by Google App Engine
This is Rietveld 408576698