Issue 1148423004: Revert of Fixed a couple of failing DCHECK(has_pending_exception()).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1148423004: Revert of Fixed a couple of failing DCHECK(has_pending_exception()). (Closed)

Created:
5 years, 7 months ago by Igor Sheludko

Modified:
5 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Fixed a couple of failing DCHECK(has_pending_exception()). (patchset #1 id:1 of https://codereview.chromium.org/1151373002/) Reason for revert: Broke V8 Linux - nosnap. Original issue's description: > Fixed a couple of failing DCHECK(has_pending_exception()). > > BUG=chromium:491062 > LOG=N > > Committed: https://crrev.com/62b56507cce3c57a2e1aebce6d34f29b3b64e762 > Cr-Commit-Position: refs/heads/master@{#28617} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:491062 Committed: https://crrev.com/d2334e901ca2371af48719c29dd3d7e52af5990b Cr-Commit-Position: refs/heads/master@{#28619}

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -27 lines)			Patch
M	src/debug.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/runtime/runtime-debug.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	test/mjsunit/regress/regress-crbug-491062.js	View	1 chunk	+0 lines, -22 lines	0 comments	Download

Total messages: 4 (0 generated)

Igor Sheludko

Created Revert of Fixed a couple of failing DCHECK(has_pending_exception()).

5 years, 7 months ago (2015-05-26 10:28:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148423004/1

5 years, 7 months ago (2015-05-26 10:28:13 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-26 10:28:44 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d2334e901ca2371af48719c29dd3d7e52af5990b
Cr-Commit-Position: refs/heads/master@{#28619}