Implement Reactive Configuration in Background Tracing

content/browser/tracing/background_tracing_config_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "content/public/browser/background_tracing_preemptive_config.h"
 #include "content/public/browser/background_tracing_reactive_config.h"
@@ skipping 95 matching lines @@
   // Invalid tracing rule type
   EXPECT_FALSE(ReadFromJSONString(
       "{\"mode\":\"reactive\","
       "\"configs\": [{\"rule\": []}]}"));
   EXPECT_FALSE(ReadFromJSONString(
       "{\"mode\":\"reactive\","
       "\"configs\": [{\"rule\": \"\"}]}"));
   EXPECT_FALSE(ReadFromJSONString(
       "{\"mode\":\"reactive\","
       "\"configs\": [{\"rule\": "
-      "\"trace_on_trigger_until_10s_or_trigger_or_full\"}]}"));
+      "\"trace_for_10s_or_trigger_or_full\"}]}"));
 
   EXPECT_FALSE(ReadFromJSONString(
       "{\"mode\":\"reactive\","
       "\"configs\": [{\"rule\": "
-      "\"trace_on_trigger_until_10s_or_trigger_or_full\", \"category\": "
+      "\"trace_for_10s_or_trigger_or_full\", \"category\": "
       "[]}]}"));
   EXPECT_FALSE(ReadFromJSONString(
       "{\"mode\":\"reactive\","
       "\"configs\": [{\"rule\": "
-      "\"trace_on_trigger_until_10s_or_trigger_or_full\", \"category\": "
+      "\"trace_for_10s_or_trigger_or_full\", \"category\": "
       "\"\"}]}"));
   EXPECT_FALSE(ReadFromJSONString(
       "{\"mode\":\"reactive\","
       "\"configs\": [{\"rule\": "
-      "\"trace_on_trigger_until_10s_or_trigger_or_full\", \"category\": "
+      "\"trace_for_10s_or_trigger_or_full\", \"category\": "
       "\"benchmark\"}]}"));
 
   EXPECT_FALSE(ReadFromJSONString(
       "{\"mode\":\"reactive\","
       "\"configs\": [{\"rule\": "
-      "\"trace_on_trigger_until_10s_or_trigger_or_full\", \"category\": "
+      "\"trace_for_10s_or_trigger_or_full\", \"category\": "
       "\"benchmark\", \"trigger_name\": []}]}"));
   EXPECT_FALSE(ReadFromJSONString(
       "{\"mode\":\"reactive\","
       "\"configs\": [{\"rule\": "
-      "\"trace_on_trigger_until_10s_or_trigger_or_full\", \"category\": "
+      "\"trace_for_10s_or_trigger_or_full\", \"category\": "
       "\"benchmark\", \"trigger_name\": 0}]}"));
 }
 
 TEST_F(BackgroundTracingConfigTest, PreemptiveConfigFromValidString) {
   scoped_ptr<BackgroundTracingPreemptiveConfig> config;
 
   config = ReadPreemptiveFromJSONString(
       "{\"mode\":\"PREEMPTIVE_TRACING_MODE\", \"category\": "
       "\"BENCHMARK\",\"configs\": []}");
   EXPECT_TRUE(config);
@@ skipping 46 matching lines @@
   scoped_ptr<BackgroundTracingReactiveConfig> config;
 
   config = ReadReactiveFromJSONString(
       "{\"mode\":\"REACTIVE_TRACING_MODE\", \"configs\": []}");
   EXPECT_TRUE(config);
   EXPECT_EQ(config->mode, BackgroundTracingConfig::REACTIVE_TRACING_MODE);
   EXPECT_EQ(config->configs.size(), 0u);
 
   config = ReadReactiveFromJSONString(
       "{\"mode\":\"REACTIVE_TRACING_MODE\",\"configs\": [{\"rule\": "
-      "\"TRACE_ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL\", "
+      "\"TRACE_FOR_10S_OR_TRIGGER_OR_FULL\", "
       "\"category\": \"BENCHMARK\", \"trigger_name\": \"foo\"}]}");
   EXPECT_TRUE(config);
   EXPECT_EQ(config->mode, BackgroundTracingConfig::REACTIVE_TRACING_MODE);
   EXPECT_EQ(config->configs.size(), 1u);
   EXPECT_EQ(config->configs[0].type,
-            BackgroundTracingReactiveConfig::
-                TRACE_ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL);
+            BackgroundTracingReactiveConfig::TRACE_FOR_10S_OR_TRIGGER_OR_FULL);
   EXPECT_EQ(config->configs[0].trigger_name, "foo");
   EXPECT_EQ(config->configs[0].category_preset,
             BackgroundTracingConfig::BENCHMARK);
 
   config = ReadReactiveFromJSONString(
       "{\"mode\":\"REACTIVE_TRACING_MODE\",\"configs\": [{\"rule\": "
-      "\"TRACE_ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL\", "
+      "\"TRACE_FOR_10S_OR_TRIGGER_OR_FULL\", "
       "\"category\": \"BENCHMARK_DEEP\", \"trigger_name\": \"foo\"}]}");
   EXPECT_TRUE(config);
   EXPECT_EQ(config->mode, BackgroundTracingConfig::REACTIVE_TRACING_MODE);
   EXPECT_EQ(config->configs.size(), 1u);
   EXPECT_EQ(config->configs[0].type,
-            BackgroundTracingReactiveConfig::
-                TRACE_ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL);
+            BackgroundTracingReactiveConfig::TRACE_FOR_10S_OR_TRIGGER_OR_FULL);
   EXPECT_EQ(config->configs[0].trigger_name, "foo");
   EXPECT_EQ(config->configs[0].category_preset,
             BackgroundTracingConfig::BENCHMARK_DEEP);
 
   config = ReadReactiveFromJSONString(
       "{\"mode\":\"REACTIVE_TRACING_MODE\",\"configs\": [{\"rule\": "
-      "\"TRACE_ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL\", "
+      "\"TRACE_FOR_10S_OR_TRIGGER_OR_FULL\", "
       "\"category\": \"BENCHMARK_DEEP\", \"trigger_name\": "
       "\"foo1\"},{\"rule\": "
-      "\"TRACE_ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL\", "
+      "\"TRACE_FOR_10S_OR_TRIGGER_OR_FULL\", "
       "\"category\": \"BENCHMARK_DEEP\", \"trigger_name\": \"foo2\"}]}");
   EXPECT_TRUE(config);
   EXPECT_EQ(config->mode, BackgroundTracingConfig::REACTIVE_TRACING_MODE);
   EXPECT_EQ(config->configs.size(), 2u);
   EXPECT_EQ(config->configs[0].type,
-            BackgroundTracingReactiveConfig::
-                TRACE_ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL);
+            BackgroundTracingReactiveConfig::TRACE_FOR_10S_OR_TRIGGER_OR_FULL);
   EXPECT_EQ(config->configs[0].trigger_name, "foo1");
   EXPECT_EQ(config->configs[0].category_preset,
             BackgroundTracingConfig::BENCHMARK_DEEP);
   EXPECT_EQ(config->configs[1].type,
-            BackgroundTracingReactiveConfig::
-                TRACE_ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL);
+            BackgroundTracingReactiveConfig::TRACE_FOR_10S_OR_TRIGGER_OR_FULL);
   EXPECT_EQ(config->configs[1].trigger_name, "foo2");
   EXPECT_EQ(config->configs[1].category_preset,
             BackgroundTracingConfig::BENCHMARK_DEEP);
 }
 
 TEST_F(BackgroundTracingConfigTest, ValidPreemptiveConfigToString) {
   scoped_ptr<BackgroundTracingPreemptiveConfig> config(
       new BackgroundTracingPreemptiveConfig());
 
   // Default values
@@ skipping 76 matching lines @@
 
   // Default values
   EXPECT_EQ(ConfigToString(config.get()),
             "{\"configs\":[],\"mode\":\"REACTIVE_TRACING_MODE\"}");
 
   {
     config.reset(new BackgroundTracingReactiveConfig());
 
     BackgroundTracingReactiveConfig::TracingRule rule;
     rule.type = BackgroundTracingReactiveConfig::
-        TRACE_ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL;
+        TRACE_FOR_10S_OR_TRIGGER_OR_FULL;
     rule.trigger_name = "foo";
     rule.category_preset = BackgroundTracingConfig::BENCHMARK_DEEP;
     config->configs.push_back(rule);
     EXPECT_EQ(ConfigToString(config.get()),
               "{\"configs\":[{\"category\":\"BENCHMARK_DEEP\",\"rule\":\"TRACE_"
-              "ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL\",\"trigger_"
-              "name\":\"foo\"}],\"mode\":\"REACTIVE_TRACING_MODE\"}");
+              "FOR_10S_OR_TRIGGER_OR_FULL\",\"trigger_name\":\"foo\"}],\"mode\""
+              ":\"REACTIVE_TRACING_MODE\"}");
   }
 
   {
     config.reset(new BackgroundTracingReactiveConfig());
 
     BackgroundTracingReactiveConfig::TracingRule rule;
     rule.type = BackgroundTracingReactiveConfig::
-        TRACE_ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL;
+        TRACE_FOR_10S_OR_TRIGGER_OR_FULL;
     rule.trigger_name = "foo1";
     rule.category_preset = BackgroundTracingConfig::BENCHMARK_DEEP;
     config->configs.push_back(rule);
     rule.trigger_name = "foo2";
     config->configs.push_back(rule);
     EXPECT_EQ(ConfigToString(config.get()),
               "{\"configs\":[{\"category\":\"BENCHMARK_DEEP\",\"rule\":\"TRACE_"
-              "ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL\",\"trigger_"
-              "name\":\"foo1\"},{\"category\":\"BENCHMARK_DEEP\",\"rule\":"
-              "\"TRACE_ON_MANUAL_TRIGGER_UNTIL_10S_OR_NEXT_TRIGGER_OR_FULL\","
-              "\"trigger_name\":\"foo2\"}],\"mode\":\"REACTIVE_TRACING_"
-              "MODE\"}");
+              "FOR_10S_OR_TRIGGER_OR_FULL\",\"trigger_name\":\"foo1\"},{"
+              "\"category\":\"BENCHMARK_DEEP\",\"rule\":\"TRACE_FOR_10S_OR_"
+              "TRIGGER_OR_FULL\",\"trigger_name\":\"foo2\"}],\"mode\":"
+              "\"REACTIVE_TRACING_MODE\"}");
   }
 }
 
 }  // namspace content