Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1356)

Unified Diff: Source/modules/serviceworkers/ServiceWorker.h

Issue 1148383012: Oilpan: prefer eager finalization over prefinalizers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: expand&improve comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/modules/serviceworkers/ServiceWorker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/ServiceWorker.h
diff --git a/Source/modules/serviceworkers/ServiceWorker.h b/Source/modules/serviceworkers/ServiceWorker.h
index e63ff4b52d530424a1a1da7834100f621c592f58..b7fd80387c2b8754acd971aec78af200589a6c15 100644
--- a/Source/modules/serviceworkers/ServiceWorker.h
+++ b/Source/modules/serviceworkers/ServiceWorker.h
@@ -48,13 +48,15 @@ class ScriptPromiseResolver;
class MODULES_EXPORT ServiceWorker final : public AbstractWorker, public WebServiceWorkerProxy {
DEFINE_WRAPPERTYPEINFO();
- WILL_BE_USING_PRE_FINALIZER(ServiceWorker, dispose);
public:
typedef WebServiceWorker WebType;
static PassRefPtrWillBeRawPtr<ServiceWorker> from(ExecutionContext*, WebType*);
~ServiceWorker() override;
+ // Eager finalization needed to promptly release owned WebServiceWorker.
+ EAGERLY_FINALIZE();
+
void postMessage(ExecutionContext*, PassRefPtr<SerializedScriptValue> message, const MessagePortArray*, ExceptionState&);
void terminate(ExceptionState&);
@@ -77,8 +79,6 @@ private:
virtual bool hasPendingActivity() const override;
virtual void stop() override;
- void dispose();
-
OwnPtr<WebServiceWorker> m_outerWorker;
bool m_wasStopped;
};
« no previous file with comments | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/modules/serviceworkers/ServiceWorker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698