Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: Source/core/dom/MutationObserver.h

Issue 1148383012: Oilpan: prefer eager finalization over prefinalizers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: expand&improve comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptPromiseResolver.cpp ('k') | Source/core/dom/MutationObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/MutationObserver.h
diff --git a/Source/core/dom/MutationObserver.h b/Source/core/dom/MutationObserver.h
index 157ce4ca869985ad9e0abf3d62bccfdc183425aa..deda1e3f73b5051d82d59060e8ce8ca228f3e4e3 100644
--- a/Source/core/dom/MutationObserver.h
+++ b/Source/core/dom/MutationObserver.h
@@ -60,7 +60,6 @@ using MutationRecordVector = WillBeHeapVector<RefPtrWillBeMember<MutationRecord>
class MutationObserver final : public RefCountedWillBeGarbageCollectedFinalized<MutationObserver>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
- WILL_BE_USING_PRE_FINALIZER(MutationObserver, dispose);
public:
enum MutationType {
ChildList = 1 << 0,
@@ -96,6 +95,8 @@ public:
WillBeHeapHashSet<RawPtrWillBeMember<Node>> getObservedNodes() const;
+ // Eagerly finalized as destructor accesses heap object members.
+ EAGERLY_FINALIZE();
DECLARE_TRACE();
private:
@@ -105,8 +106,6 @@ private:
void deliver();
bool shouldBeSuspended() const;
- void dispose();
-
OwnPtrWillBeMember<MutationCallback> m_callback;
MutationRecordVector m_records;
MutationObserverRegistrationSet m_registrations;
« no previous file with comments | « Source/bindings/core/v8/ScriptPromiseResolver.cpp ('k') | Source/core/dom/MutationObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698