Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1716)

Unified Diff: Source/platform/speech/PlatformSpeechSynthesizer.h

Issue 1148383012: Oilpan: prefer eager finalization over prefinalizers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/speech/PlatformSpeechSynthesizer.h
diff --git a/Source/platform/speech/PlatformSpeechSynthesizer.h b/Source/platform/speech/PlatformSpeechSynthesizer.h
index f808750fe3102bb50409dfa7fcb5bda64ac19400..01df344a6e290f689fbee387ef346c7e9dcce57c 100644
--- a/Source/platform/speech/PlatformSpeechSynthesizer.h
+++ b/Source/platform/speech/PlatformSpeechSynthesizer.h
@@ -58,12 +58,10 @@ protected:
class PLATFORM_EXPORT PlatformSpeechSynthesizer : public GarbageCollectedFinalized<PlatformSpeechSynthesizer> {
WTF_MAKE_NONCOPYABLE(PlatformSpeechSynthesizer);
- USING_PRE_FINALIZER(PlatformSpeechSynthesizer, dispose);
public:
static PlatformSpeechSynthesizer* create(PlatformSpeechSynthesizerClient*);
virtual ~PlatformSpeechSynthesizer();
- void dispose();
const HeapVector<Member<PlatformSpeechSynthesisVoice>>& voiceList() const { return m_voiceList; }
virtual void speak(PlatformSpeechSynthesisUtterance*);
@@ -75,6 +73,8 @@ public:
void setVoiceList(HeapVector<Member<PlatformSpeechSynthesisVoice>>&);
+ // Eager finalization to promptly release owned WebSpeechSynthesizer.
+ EAGERLY_FINALIZE();
DECLARE_VIRTUAL_TRACE();
protected:

Powered by Google App Engine
This is Rietveld 408576698