Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: Source/bindings/core/v8/ScriptPromiseResolver.h

Issue 1148383012: Oilpan: prefer eager finalization over prefinalizers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptPromiseResolver.h
diff --git a/Source/bindings/core/v8/ScriptPromiseResolver.h b/Source/bindings/core/v8/ScriptPromiseResolver.h
index 6af0ff44cb364f90c211cc6300a0e535a87015a9..beb7ba412a41f8827d1dbbd6a84aef4a0885f0c2 100644
--- a/Source/bindings/core/v8/ScriptPromiseResolver.h
+++ b/Source/bindings/core/v8/ScriptPromiseResolver.h
@@ -28,9 +28,6 @@ namespace blink {
// will be ignored.
class CORE_EXPORT ScriptPromiseResolver : public RefCountedWillBeRefCountedGarbageCollected<ScriptPromiseResolver>, public ActiveDOMObject {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ScriptPromiseResolver);
-#if ENABLE(ASSERT)
- WILL_BE_USING_PRE_FINALIZER(ScriptPromiseResolver, assertNotPending);
-#endif
WTF_MAKE_NONCOPYABLE(ScriptPromiseResolver);
public:
static PassRefPtrWillBeRawPtr<ScriptPromiseResolver> create(ScriptState* scriptState)
@@ -40,7 +37,11 @@ public:
return resolver.release();
}
-#if !ENABLE(OILPAN) && ENABLE(ASSERT)
+#if ENABLE(ASSERT)
+ // Eagerly finalized to allow assertNotPending() access
+ // other heap objects.
+ EAGERLY_FINALIZE();
+
~ScriptPromiseResolver() override
{
assertNotPending();
haraken 2015/06/04 01:02:31 Now you can inline assertNotPending() here.
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptPromiseResolver.cpp » ('j') | Source/core/dom/MutationObserver.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698