Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1148383007: Add {Map,Set}::AsArray to the API (Closed)

Created:
5 years, 7 months ago by adamk
Modified:
5 years, 7 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add {Map,Set}::AsArray to the API These return arrays representing the current contents of the given Map/Set. They are similar to what would be returned by the JS code: Array.from(collection) except that they are guaranteed side-effect free. This will be useful in implementing structured clone which, as specified in HTML, speaks in terms of the internal [[MapData]] and [[SetData]] slots without going through the exposed iteration ES semantics. BUG=v8:3340 LOG=y Committed: https://crrev.com/a8d9c58b1f618f518dc3a5a73023e6847544979f Cr-Commit-Position: refs/heads/master@{#28640}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
M include/v8.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 chunks +46 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-26 15:43:02 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 7 months ago (2015-05-26 16:33:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148383007/20001
5 years, 7 months ago (2015-05-26 17:45:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148383007/20001
5 years, 7 months ago (2015-05-26 17:46:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-26 18:13:27 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 18:13:38 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8d9c58b1f618f518dc3a5a73023e6847544979f
Cr-Commit-Position: refs/heads/master@{#28640}

Powered by Google App Engine
This is Rietveld 408576698