core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp - Issue 1148353002: Fix four annoying warnings:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp

Issue 1148353002: Fix four annoying warnings: (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Remove pragma entirely, fix busted logic. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp

index 691981cb10b5a96627513e69c912f98ac9d8ea24..d18caab217150c5597d25fb22652b41f0669aa61 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp

@@ -232,11 +232,9 @@ ICodec_ScanlineDecoder* FPDFAPI_CreateFlateDecoder(FX_LPCBYTE src_buf, FX_DWORD

int nComps, int bpc, const CPDF_Dictionary* pParams)

{

int predictor = 0;

- FX_BOOL bEarlyChange = TRUE;

int Colors = 0, BitsPerComponent = 0, Columns = 0;

if (pParams) {

predictor = ((CPDF_Dictionary*)pParams)->GetInteger(FX_BSTRC("Predictor"));

- bEarlyChange = ((CPDF_Dictionary*)pParams)->GetInteger(FX_BSTRC("EarlyChange"), 1);

Colors = pParams->GetInteger(FX_BSTRC("Colors"), 1);

BitsPerComponent = pParams->GetInteger(FX_BSTRC("BitsPerComponent"), 8);

Columns = pParams->GetInteger(FX_BSTRC("Columns"), 1);