Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: lib/runtime/dart/isolate.js

Issue 1148333003: No dynamic at runtime (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Address comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/runtime/dart/isolate.js
diff --git a/lib/runtime/dart/isolate.js b/lib/runtime/dart/isolate.js
index 30e5eaac73c773f9a74e06fa624f132375d54254..f01665e3082cd0d66bb1303b1c6a825865dd14d0 100644
--- a/lib/runtime/dart/isolate.js
+++ b/lib/runtime/dart/isolate.js
@@ -33,7 +33,7 @@ var async = dart.import(async);
static spawn(entryPoint, message, opts) {
let paused = opts && 'paused' in opts ? opts.paused : false;
try {
- return dart.as(_isolate_helper.IsolateNatives.spawnFunction(entryPoint, message, paused).then(dart.fn(msg => new Isolate(dart.as(dart.dindex(msg, 1), SendPort), {pauseCapability: dart.as(dart.dindex(msg, 2), Capability), terminateCapability: dart.as(dart.dindex(msg, 3), Capability)}), Isolate, [dart.dynamic])), async.Future$(Isolate));
+ return dart.as(_isolate_helper.IsolateNatives.spawnFunction(entryPoint, message, paused).then(dart.fn(msg => new Isolate(dart.as(dart.dindex(msg, 1), SendPort), {pauseCapability: dart.as(dart.dindex(msg, 2), Capability), terminateCapability: dart.as(dart.dindex(msg, 3), Capability)}), Isolate, [core.Object])), async.Future$(Isolate));
} catch (e) {
let st = dart.stackTrace(e);
return new (async.Future$(Isolate)).error(e, st);
@@ -55,7 +55,7 @@ var async = dart.import(async);
} else if (args != null) {
throw new core.ArgumentError(`Args must be a list of Strings ${args}`);
}
- return dart.as(_isolate_helper.IsolateNatives.spawnUri(uri, args, message, paused).then(dart.fn(msg => new Isolate(dart.as(dart.dindex(msg, 1), SendPort), {pauseCapability: dart.as(dart.dindex(msg, 2), Capability), terminateCapability: dart.as(dart.dindex(msg, 3), Capability)}), Isolate, [dart.dynamic])), async.Future$(Isolate));
+ return dart.as(_isolate_helper.IsolateNatives.spawnUri(uri, args, message, paused).then(dart.fn(msg => new Isolate(dart.as(dart.dindex(msg, 1), SendPort), {pauseCapability: dart.as(dart.dindex(msg, 2), Capability), terminateCapability: dart.as(dart.dindex(msg, 3), Capability)}), Isolate, [core.Object])), async.Future$(Isolate));
} catch (e) {
let st = dart.stackTrace(e);
return new (async.Future$(Isolate)).error(e, st);
@@ -137,7 +137,7 @@ var async = dart.import(async);
let error = new RemoteError(errorDescription, stackDescription);
controller.addError(error, error.stackTrace);
};
- dart.fn(handleError, dart.void, [dart.dynamic]);
+ dart.fn(handleError, dart.void, [core.Object]);
controller = new async.StreamController.broadcast({sync: true, onListen: dart.fn((() => {
port = new RawReceivePort(handleError);
this.addErrorListener(port.sendPort);
@@ -163,8 +163,8 @@ var async = dart.import(async);
removeErrorListener: [dart.void, [SendPort]]
}),
statics: () => ({
- spawn: [async.Future$(Isolate), [dart.functionType(dart.void, [dart.dynamic]), dart.dynamic], {ause: core.bool}],
- spawnUri: [async.Future$(Isolate), [core.Uri, core.List$(core.String), dart.dynamic], {ause: core.bool, ackageRoo: core.Uri}]
+ spawn: [async.Future$(Isolate), [dart.functionType(dart.void, [dart.bottom]), core.Object], {ause: core.bool}],
+ spawnUri: [async.Future$(Isolate), [core.Uri, core.List$(core.String), core.Object], {ause: core.bool, ackageRoo: core.Uri}]
}),
names: ['spawn', 'spawnUri']
});
« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/runtime/dart/math.js » ('j') | lib/runtime/dart_runtime.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698