No dynamic at runtime

No dynamic at runtime.

Reify dynamic as bottom or Object as appropriate in the generated code.

For general function types, dynamic parameters become bottom, and all other uses of dynamic become Object.

For concrete function types (the rtti attached to function objects) dynamic parameters also become Object.

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/cb4ac2a65c306b170a98479bd40bbeaa9677db19

[Leaf, 2015-05-20 22:09:27]

leafp@google.com changed reviewers:
+ vsm@google.com

[vsm, 2015-05-20 23:03:10]

lgtm

https://codereview.chromium.org/1148333003/diff/1/lib/runtime/dart_runtime.js
File lib/runtime/dart_runtime.js (right):

https://codereview.chromium.org/1148333003/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:574: t = build();
yikes ... perhaps we should move Object to this file?

https://codereview.chromium.org/1148333003/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1148333003/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:1187: {bool dynamicIsObject: false}) {
Perhaps use either dynamicIsBottom here or dynamicIsObject above consistently?

[Leaf, 2015-05-20 23:35:29]

https://codereview.chromium.org/1148333003/diff/1/lib/runtime/dart_runtime.js
File lib/runtime/dart_runtime.js (right):

https://codereview.chromium.org/1148333003/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:574: t = build();
On 2015/05/20 23:03:10, vsm wrote:
> yikes ... perhaps we should move Object to this file?

Yes, figuring out some way to architect things so that the dependencies between
the dart.XXX and the essential few core.YYY types that they refer to become more
manageable would be good.

https://codereview.chromium.org/1148333003/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1148333003/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:1187: {bool dynamicIsObject: false}) {
On 2015/05/20 23:03:10, vsm wrote:
> Perhaps use either dynamicIsBottom here or dynamicIsObject above consistently?

Done.

[Leaf, 2015-05-20 23:36:30]

Committed patchset #2 (id:20001) manually as
cb4ac2a65c306b170a98479bd40bbeaa9677db19 (presubmit successful).

[vsm, 2015-05-21 20:08:48]

Just a followup comment

https://codereview.chromium.org/1148333003/diff/20001/lib/runtime/dart_runtim...
File lib/runtime/dart_runtime.js (right):

https://codereview.chromium.org/1148333003/diff/20001/lib/runtime/dart_runtim...
lib/runtime/dart_runtime.js:969: // which is too late.
John and I were just discussing this.  I *think* this should only be core.Object
for class types.  For typedef (which also use this function), it should probably
stay as dynamic.

E.g., in
typedef T Foo<T>(T t);

Plain Foo should be dynamic->dynamic (effectively, bottom->top).

[Leaf, 2015-05-21 22:47:34]

https://codereview.chromium.org/1148333003/diff/20001/lib/runtime/dart_runtim...
File lib/runtime/dart_runtime.js (right):

https://codereview.chromium.org/1148333003/diff/20001/lib/runtime/dart_runtim...
lib/runtime/dart_runtime.js:969: // which is too late.
On 2015/05/21 20:08:47, vsm wrote:
> John and I were just discussing this.  I *think* this should only be
core.Object
> for class types.  For typedef (which also use this function), it should
probably
> stay as dynamic.
> 
> E.g., in
> typedef T Foo<T>(T t);
> 
> Plain Foo should be dynamic->dynamic (effectively, bottom->top).

It either needs to stay as dynamic, or get canonicalized appropriately,
depending on whether we want to be reifying dynamic into Object and bottom, or
whether we want to keep it around.

[vsm, 2015-05-22 15:52:04]

https://codereview.chromium.org/1148333003/diff/20001/lib/runtime/dart_runtim...
File lib/runtime/dart_runtime.js (right):

https://codereview.chromium.org/1148333003/diff/20001/lib/runtime/dart_runtim...
lib/runtime/dart_runtime.js:969: // which is too late.
On 2015/05/21 22:47:34, Leaf wrote:
> On 2015/05/21 20:08:47, vsm wrote:
> > John and I were just discussing this.  I *think* this should only be
> core.Object
> > for class types.  For typedef (which also use this function), it should
> probably
> > stay as dynamic.
> > 
> > E.g., in
> > typedef T Foo<T>(T t);
> > 
> > Plain Foo should be dynamic->dynamic (effectively, bottom->top).
> 
> It either needs to stay as dynamic, or get canonicalized appropriately,
> depending on whether we want to be reifying dynamic into Object and bottom, or
> whether we want to keep it around.

Ah, I was thinking that the reified type of any obj/function is never a typedef
- so it shouldn't matter.  But that's not quite true.  It can contain a typedef.
 Damn higher order types.  :-)

And, of course, if we use this same utility for generic methods....

So, it looks we'll need something more sophisticated?