Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 1148323009: Don't update primary color if brand color is not enabled (Closed)

Created:
5 years, 6 months ago by Yusuf
Modified:
5 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't update primary color if brand color is not enabled We always update the model refreshSelectedTab, but that should not end up making any visual updates. In onPrimaryColorChanged we should be checking the model for isUsingBrandColor. BUG=497241 Committed: https://crrev.com/ca0908a1dab9f9cb6081e5106698ed4caa7e9127 Cr-Commit-Position: refs/heads/master@{#333101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java_staging/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yusuf
5 years, 6 months ago (2015-06-05 17:52:02 UTC) #2
Ted C
lgtm
5 years, 6 months ago (2015-06-05 18:05:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148323009/1
5 years, 6 months ago (2015-06-05 18:09:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 18:38:07 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 19:06:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca0908a1dab9f9cb6081e5106698ed4caa7e9127
Cr-Commit-Position: refs/heads/master@{#333101}

Powered by Google App Engine
This is Rietveld 408576698