Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1148323008: Eliminate SVGTextChunkBuilder::m_textBoxTransformations (Closed)

Created:
5 years, 6 months ago by fs
Modified:
5 years, 6 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-rendering, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Eliminate SVGTextChunkBuilder::m_textBoxTransformations Nothing touches SVGTextFragment::lengthAdjustTransform between the calls to processTextChunks() and finalizeTransformMatrices(), so the scaling transform can be applied directly during the former, and the latter can be removed along with the HashMap it uses. Also change some fragment loops to for-range style. BUG=486669 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -36 lines) Patch
M Source/core/layout/svg/SVGTextChunkBuilder.h View 3 chunks +2 lines, -5 lines 0 comments Download
M Source/core/layout/svg/SVGTextChunkBuilder.cpp View 5 chunks +12 lines, -26 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 6 months ago (2015-06-05 18:46:27 UTC) #2
pdr.
On 2015/06/05 at 18:46:27, fs wrote: > LGTM!
5 years, 6 months ago (2015-06-05 19:49:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148323008/1
5 years, 6 months ago (2015-06-05 19:50:22 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 19:54:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196601

Powered by Google App Engine
This is Rietveld 408576698