extensions/browser/api/runtime/runtime_apitest.cc - Issue 1148323007: [Extensions] Introduce a ScopedExtensionDialogAutoConfirm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/runtime/runtime_apitest.cc

Issue 1148323007: [Extensions] Introduce a ScopedExtensionDialogAutoConfirm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ben's Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/management/management_api.cc ('K') | « extensions/browser/api/management/management_api.cc ('k') | extensions/browser/extension_dialog_auto_confirm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/runtime/runtime_apitest.cc

diff --git a/extensions/browser/api/runtime/runtime_apitest.cc b/extensions/browser/api/runtime/runtime_apitest.cc

index 49614d0894e166d457181ccb5442af8782b14827..c3161893fd0cc91515d125968d125b0341472608 100644

--- a/extensions/browser/api/runtime/runtime_apitest.cc

+++ b/extensions/browser/api/runtime/runtime_apitest.cc

@@ -8,8 +8,8 @@

#include "chrome/browser/extensions/test_extension_dir.h"

#include "chrome/test/base/ui_test_utils.h"

#include "content/public/browser/notification_service.h"

-#include "extensions/browser/api/management/management_api.h"

#include "extensions/browser/api/runtime/runtime_api.h"

+#include "extensions/browser/extension_dialog_auto_confirm.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/test/result_catcher.h"

#include "net/test/embedded_test_server/embedded_test_server.h"

@@ -34,7 +34,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeUnprivileged) {

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeUninstallURL) {

// Auto-confirm the uninstall dialog.

- extensions::ManagementUninstallFunction::SetAutoConfirmForTest(true);

+ extensions::ScopedTestDialogAutoConfirm auto_confirm(

+ extensions::ScopedTestDialogAutoConfirm::ACCEPT);

ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("runtime")

.AppendASCII("uninstall_url")

.AppendASCII("sets_uninstall_url")));