chrome/browser/extensions/api/management/management_apitest.cc - Issue 1148323007: [Extensions] Introduce a ScopedExtensionDialogAutoConfirm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_apitest.cc

Issue 1148323007: [Extensions] Introduce a ScopedExtensionDialogAutoConfirm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_api_unittest.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_apitest.cc

diff --git a/chrome/browser/extensions/api/management/management_apitest.cc b/chrome/browser/extensions/api/management/management_apitest.cc

index d64a32e3d8a96bbfded7e81178460900c3bf1cff..91d0b66bab500b2881b0304767cac0c9099e2549 100644

--- a/chrome/browser/extensions/api/management/management_apitest.cc

+++ b/chrome/browser/extensions/api/management/management_apitest.cc

@@ -19,6 +19,7 @@

#include "chrome/common/extensions/extension_constants.h"

#include "content/public/test/test_utils.h"

#include "extensions/browser/api/management/management_api.h"

+#include "extensions/browser/extension_dialog_auto_confirm.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/test_management_policy.h"

#include "extensions/common/manifest.h"

@@ -128,7 +129,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, NoPermission) {

IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, MAYBE_Uninstall) {

LoadExtensions();

// Confirmation dialog will be shown for uninstallations except for self.

- extensions::ManagementUninstallFunction::SetAutoConfirmForTest(true);

+ extensions::ScopedTestDialogAutoConfirm auto_confirm(

+ extensions::ScopedTestDialogAutoConfirm::ACCEPT);

ASSERT_TRUE(RunExtensionSubtest("management/test", "uninstall.html"));

}

@@ -158,7 +160,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, GenerateAppForLink) {

IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest,

MAYBE_ManagementPolicyAllowed) {

LoadExtensions();

- extensions::ManagementUninstallFunction::SetAutoConfirmForTest(true);

+ extensions::ScopedTestDialogAutoConfirm auto_confirm(

+ extensions::ScopedTestDialogAutoConfirm::ACCEPT);

ExtensionService* service = extensions::ExtensionSystem::Get(

browser()->profile())->extension_service();

EXPECT_TRUE(service->GetExtensionById(extension_ids_["enabled_extension"],