[Extensions] Introduce a ScopedExtensionDialogAutoConfirm

chrome/browser/extensions/extension_reenabler_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_reenabler.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_service_test_base.h"
 #include "chrome/browser/extensions/extension_system_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/crx_file/id_util.h"
+#include "extensions/browser/extension_dialog_auto_confirm.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/management_policy.h"
 #include "extensions/browser/test_extensions_browser_client.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_builder.h"
 #include "extensions/common/value_builder.h"
 
 namespace extensions {
 
 namespace {
@@ skipping 129 matching lines @@
   // Check that the ExtensionReenabler can re-enable disabled extensions.
   {
     // Disable the extension due to a permissions increase (the only type of
     // disablement we handle with the ExtensionReenabler so far).
     service()->DisableExtension(extension->id(),
                                 Extension::DISABLE_PERMISSIONS_INCREASE);
     // Sanity check that it's disabled.
     EXPECT_TRUE(registry()->disabled_extensions().Contains(extension->id()));
 
     // Automatically confirm install prompts.
-    ExtensionInstallPrompt::g_auto_confirm_for_tests =
-        ExtensionInstallPrompt::ACCEPT;
+    ScopedTestDialogAutoConfirm auto_confirm(
+        ScopedTestDialogAutoConfirm::ACCEPT);
 
     // Run the ExtensionReenabler.
     scoped_ptr<ExtensionReenabler> extension_reenabler =
         ExtensionReenabler::PromptForReenable(extension,
                                               profile(),
                                               nullptr,  // No web contents.
                                               GURL(),  // No referrer.
                                               callback_helper.GetCallback());
     base::RunLoop().RunUntilIdle();
 
     // The extension should be enabled.
     EXPECT_TRUE(registry()->enabled_extensions().Contains(extension->id()));
     EXPECT_TRUE(
         callback_helper.result_matches(ExtensionReenabler::REENABLE_SUCCESS));
   }
 
   // Check that we don't re-enable extensions that must remain disabled, and
   // that the re-enabler reports failure correctly.
   {
+    ScopedTestDialogAutoConfirm auto_confirm(
+        ScopedTestDialogAutoConfirm::ACCEPT);
+
     ManagementPolicy* management_policy =
         ExtensionSystem::Get(browser_context())->management_policy();
     ASSERT_TRUE(management_policy);
     TestManagementProvider test_provider;
     management_policy->RegisterProvider(&test_provider);
     service()->DisableExtension(extension->id(),
                                 Extension::DISABLE_PERMISSIONS_INCREASE);
 
     scoped_ptr<ExtensionReenabler> extension_reenabler =
         ExtensionReenabler::PromptForReenable(extension,
                                               profile(),
                                               nullptr,  // No web contents.
                                               GURL(),  // No referrer.
                                               callback_helper.GetCallback());
     base::RunLoop().RunUntilIdle();
 
     // The extension should be enabled.
     EXPECT_TRUE(registry()->disabled_extensions().Contains(extension->id()));
     EXPECT_TRUE(
         callback_helper.result_matches(ExtensionReenabler::NOT_ALLOWED));
 
     management_policy->UnregisterProvider(&test_provider);
   }
 
   // Check that canceling the re-enable prompt doesn't re-enable the extension.
   {
     // Disable it again, and try canceling the prompt.
     service()->DisableExtension(extension->id(),
                                 Extension::DISABLE_PERMISSIONS_INCREASE);
-    ExtensionInstallPrompt::g_auto_confirm_for_tests =
-        ExtensionInstallPrompt::CANCEL;
+    ScopedTestDialogAutoConfirm auto_confirm(
+        ScopedTestDialogAutoConfirm::CANCEL);
     scoped_ptr<ExtensionReenabler> extension_reenabler =
         ExtensionReenabler::PromptForReenable(extension,
                                               profile(),
                                               nullptr,  // No web contents.
                                               GURL(),  // No referrer.
                                               callback_helper.GetCallback());
     base::RunLoop().RunUntilIdle();
 
     // The extension should remain disabled.
     EXPECT_TRUE(registry()->disabled_extensions().Contains(extension->id()));
     EXPECT_TRUE(
         callback_helper.result_matches(ExtensionReenabler::USER_CANCELED));
   }
 
   // Test that if the extension is re-enabled while the prompt is active, the
   // prompt exits and reports success.
   {
-    // Don't auto-confirm, so that the prompt "stays around".
-    ExtensionInstallPrompt::g_auto_confirm_for_tests =
-        ExtensionInstallPrompt::NONE;
     base::RunLoop run_loop;
     scoped_ptr<ExtensionReenabler> extension_reenabler =
         ExtensionReenabler::PromptForReenableWithPromptForTest(
             extension,
             profile(),
             callback_helper.GetCallback(),
             callback_helper.CreateTestPrompt(nullptr, run_loop.QuitClosure()));
     run_loop.Run();
 
     // We shouldn't have any result yet (the user hasn't confirmed or canceled).
@@ skipping 22 matching lines @@
     EXPECT_FALSE(callback_helper.has_result());
     // Destroy the reenabler to simulate the owning context being shut down
     // (e.g., the tab closing).
     extension_reenabler.reset();
     EXPECT_TRUE(
         callback_helper.result_matches(ExtensionReenabler::ABORTED));
   }
 }
 
 }  // namespace extensions