Add the ability to schedule any pending lossy prefs to be written.

Add the ability to schedule any pending lossy prefs to be written.

This causes a write to be scheduled for any changes that have been made
to lossy prefs. This allows pres which are mostly lossy to sometimes be
treated as non-lossy.

TBR=torne@chromium.rg
BUG=491031
Committed: https://crrev.com/267305924adcdbf5f77e4e697eac14bbe87880e0
Cr-Commit-Position: refs/heads/master@{#331770}

[benwells, 2015-05-28 03:37:29]

benwells@chromium.org changed reviewers:
+ mnissler@chromium.org

[Mattias Nissler (ping if slow), 2015-05-28 07:20:24]

Wouldn't you want to add a function to PrefService as well in order to invoke
this?

https://codereview.chromium.org/1148323005/diff/40001/base/prefs/persistent_p...
File base/prefs/persistent_pref_store.h (right):

https://codereview.chromium.org/1148323005/diff/40001/base/prefs/persistent_p...
base/prefs/persistent_pref_store.h:70: // Schedule a write if there is any lossy
data pending
Nit: Missing period.

Also, would be nice to elaborate on the difference to CommitPendingWrite here,
i.e. that the latter does an immediate sync to disk, while
SchedulePendingLossyWrites() merely triggers an eventual write in case there
isn't one scheduled already.

[benwells, 2015-05-28 08:49:46]

Added the missing function to PrefService.

https://codereview.chromium.org/1148323005/diff/40001/base/prefs/persistent_p...
File base/prefs/persistent_pref_store.h (right):

https://codereview.chromium.org/1148323005/diff/40001/base/prefs/persistent_p...
base/prefs/persistent_pref_store.h:70: // Schedule a write if there is any lossy
data pending
On 2015/05/28 07:20:24, Mattias Nissler wrote:
> Nit: Missing period.
> 
> Also, would be nice to elaborate on the difference to CommitPendingWrite here,
> i.e. that the latter does an immediate sync to disk, while
> SchedulePendingLossyWrites() merely triggers an eventual write in case there
> isn't one scheduled already.

Done.

[Mattias Nissler (ping if slow), 2015-05-28 09:00:25]

LGTM

[benwells, 2015-05-28 12:02:27]

benwells@chromium.org changed reviewers:
+ torne@chromium.org

[benwells, 2015-05-28 12:03:27]

+tbr torne for fallout from adding function to PrefStore

[benwells, 2015-05-28 12:03:33]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2015-05-28 12:03:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148323005/60001

[commit-bot: I haz the power, 2015-05-28 13:08:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-28 13:09:14]

Patchset 4 (id:??) landed as
https://crrev.com/267305924adcdbf5f77e4e697eac14bbe87880e0
Cr-Commit-Position: refs/heads/master@{#331770}