Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1148323003: [turbofan] Remove frame state TODOs from VisitForInBody. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove frame state TODOs from VisitForInBody. Neither the increment nor the comparison can deoptimize, so we don't need proper frame states there. R=jarin@chromium.org Committed: https://crrev.com/a06631e9eb6bbc106707d8777c996f0e9af81047 Cr-Commit-Position: refs/heads/master@{#28669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M src/compiler/ast-graph-builder.cc View 3 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-05-27 17:27:01 UTC) #1
Jarin
lgtm
5 years, 6 months ago (2015-05-27 18:50:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148323003/1
5 years, 6 months ago (2015-05-28 04:08:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-28 04:10:47 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 04:11:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a06631e9eb6bbc106707d8777c996f0e9af81047
Cr-Commit-Position: refs/heads/master@{#28669}

Powered by Google App Engine
This is Rietveld 408576698