Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1148303007: Use parent host outer html as the key hint for pref errors. (Closed)

Created:
5 years, 6 months ago by Jeremy Klein
Modified:
5 years, 6 months ago
Reviewers:
Kyle Horimoto
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use parent host outer html as the key hint for pref errors. BUG= Committed: https://crrev.com/b1bfa0261c0b4a4ca4aa28c098f9619fa153a1f3 Cr-Commit-Position: refs/heads/master@{#333174}

Patch Set 1 #

Total comments: 1

Patch Set 2 : default to "Unknown" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/resources/settings/pref_tracker/pref_tracker.js View 1 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jeremy Klein
5 years, 6 months ago (2015-06-05 19:33:35 UTC) #2
Kyle Horimoto
lgtm https://codereview.chromium.org/1148303007/diff/1/chrome/browser/resources/settings/pref_tracker/pref_tracker.js File chrome/browser/resources/settings/pref_tracker/pref_tracker.js (right): https://codereview.chromium.org/1148303007/diff/1/chrome/browser/resources/settings/pref_tracker/pref_tracker.js#newcode75 chrome/browser/resources/settings/pref_tracker/pref_tracker.js:75: 'Pref not found. Parent control:' + parentControlHTML); nit: ...
5 years, 6 months ago (2015-06-05 20:14:20 UTC) #3
Jeremy Klein
On 2015/06/05 20:14:20, Kyle Horimoto wrote: > lgtm > > https://codereview.chromium.org/1148303007/diff/1/chrome/browser/resources/settings/pref_tracker/pref_tracker.js > File chrome/browser/resources/settings/pref_tracker/pref_tracker.js (right): ...
5 years, 6 months ago (2015-06-05 22:44:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148303007/20001
5 years, 6 months ago (2015-06-05 22:45:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 23:37:01 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 23:38:54 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b1bfa0261c0b4a4ca4aa28c098f9619fa153a1f3
Cr-Commit-Position: refs/heads/master@{#333174}

Powered by Google App Engine
This is Rietveld 408576698