Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1148303006: Re-land: Use script in depot_tools to retrieve builders from new cq.cfg (Closed)

Created:
5 years, 6 months ago by Sergiy Byelozyorov
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Use script in depot_tools to retrieve builders from new cq.cfg TBR=akuegel@chromium.org, jochen@chromium.org TEST=ran git-cl-try on this CL on Win, Mac and Linux Committed: https://crrev.com/2c7fb79b2aad9d924dcbcd663e09f3022884f502 Cr-Commit-Position: refs/heads/master@{#332369}

Patch Set 1 : Original CL #

Patch Set 2 : Only use shell=True on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -134 lines) Patch
M PRESUBMIT.py View 1 1 chunk +26 lines, -25 lines 0 comments Download
D testing/commit_queue/OWNERS View 1 chunk +0 lines, -7 lines 0 comments Download
D testing/commit_queue/config.json View 1 chunk +0 lines, -102 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Sergiy Byelozyorov
5 years, 6 months ago (2015-06-02 09:46:56 UTC) #2
Adrian Kuegel
lgtm
5 years, 6 months ago (2015-06-02 09:50:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148303006/20001
5 years, 6 months ago (2015-06-02 10:09:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/67491)
5 years, 6 months ago (2015-06-02 10:38:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148303006/20001
5 years, 6 months ago (2015-06-02 11:15:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 11:36:28 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2c7fb79b2aad9d924dcbcd663e09f3022884f502 Cr-Commit-Position: refs/heads/master@{#332369}
5 years, 6 months ago (2015-06-02 11:37:15 UTC) #12
Peter Beverloo
5 years, 6 months ago (2015-06-02 14:36:34 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1160783004/ by peter@chromium.org.

The reason for reverting is: Breaks the "git cl try" command, see chromium-dev@
and crbug.com/495219.

Traceback (most recent call last):
  File "/b/depot_tools/commit_queue.py", line 28, in <module>
    from cq_client import cq_pb2
  File "/b/depot_tools/third_party/cq_client/cq_pb2.py", line 9, in <module>
    from google.protobuf import symbol_database as _symbol_database
ImportError: cannot import name symbol_database

BUG=495219.

Powered by Google App Engine
This is Rietveld 408576698