Source/web/ServiceWorkerGlobalScopeClientImpl.cpp - Issue 1148293011: BackgroundSync sync events need to be ExtendableEvents, blink side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 1148293011: BackgroundSync sync events need to be ExtendableEvents, blink side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename unused overload to simplify later cleanup Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeClientImpl.h ('k') | Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp b/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

index c0d18481a4e27d1916c2d063552baae9deaa3eea..36c0ed46d0d4248adfe79a384ff79e9a41ab39b4 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

@@ -103,9 +103,9 @@ void ServiceWorkerGlobalScopeClientImpl::didHandlePushEvent(int pushEventID, Web

m_client.didHandlePushEvent(pushEventID, result);

}

-void ServiceWorkerGlobalScopeClientImpl::didHandleSyncEvent(int syncEventID)

+void ServiceWorkerGlobalScopeClientImpl::didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult result)

{

- m_client.didHandleSyncEvent(syncEventID);

+ m_client.didHandleSyncEvent(syncEventID, result);

}

void ServiceWorkerGlobalScopeClientImpl::didHandleCrossOriginConnectEvent(int connectEventID, bool acceptConnect)