public/web/WebServiceWorkerContextClient.h - Issue 1148293011: BackgroundSync sync events need to be ExtendableEvents, blink side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebServiceWorkerContextClient.h

Issue 1148293011: BackgroundSync sync events need to be ExtendableEvents, blink side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove unnecessary comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebServiceWorkerContextClient.h

diff --git a/public/web/WebServiceWorkerContextClient.h b/public/web/WebServiceWorkerContextClient.h

index a2af4562dc9cbfc7d64fe10418b560943f0b8846..3c20eccf6376a7184c5164d0f213f1de75bc5926 100644

--- a/public/web/WebServiceWorkerContextClient.h

+++ b/public/web/WebServiceWorkerContextClient.h

@@ -134,7 +134,9 @@ public:

// ServiceWorker specific method. Called after SyncEvent (dispatched via

// WebServiceWorkerContextProxy) is handled by the ServiceWorker's script

// context.

- virtual void didHandleSyncEvent(int syncEventID) { }

+ // TODO(chasej): crbug.com/486890 - Remove after cleanup on content side

+ virtual void didHandleSyncEventDeprecated(int syncEventID) { }

+ virtual void didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult result) { }

// ServiceWorker specific method. Called after CrossOriginConnectEvent

// (dispatched via WebServiceWorkerContextProxy) is handled by the

« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | no next file » | no next file with comments »