Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 1148293011: BackgroundSync sync events need to be ExtendableEvents, blink side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 1148293011: BackgroundSync sync events need to be ExtendableEvents, blink side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove unnecessary comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index 33e792215e224769ba8d04b2f77e63ee36c044c0..140639b04f9fdee928e660dd0d24021471328f41 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -61,7 +61,7 @@ public:

virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult) override;

virtual void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult) override;

virtual void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult) override;

- virtual void didHandleSyncEvent(int syncEventID) override;

+ virtual void didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult) override;

virtual void didHandleCrossOriginConnectEvent(int connectEventID, bool acceptConnect) override;

virtual void postMessageToClient(const WebString& clientUUID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) override;

virtual void postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient&, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) override;

« no previous file with comments | « Source/modules/serviceworkers/WaitUntilObserver.cpp ('k') | Source/web/ServiceWorkerGlobalScopeClientImpl.cpp » ('j') | no next file with comments »