BackgroundSync sync events need to be ExtendableEvents, blink side

BackgroundSync sync events need to be ExtendableEvents, blink side

This is part of a series of patches to correctly fire the Sync event as
an ExtendableEvent, instead of a regular Event

[1/4] https://codereview.chromium.org/1162243003/, content side fix
[2/4] This patch, blink side fix
[3/4] https://codereview.chromium.org/1160253004/, content browser tests
[4/4] https://codereview.chromium.org/1146063005/, cleanup

Specific changes in this patch
- Custom SyncEvent is fired, instead of generic Event
- Result of waitUntil promise is observed/captured
- Pass promise result (reject vs resolve) to client

BUG=486890
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196904

[chasej, 2015-06-04 16:44:07]

chasej@chromium.org changed reviewers:
+ jkarlin@chromium.org

[chasej, 2015-06-04 16:44:40]

Please take a look, and recommend other reviewers.

[jkarlin, 2015-06-04 17:39:43]

On 2015/06/04 16:44:40, chasej wrote:
> Please take a look, and recommend other reviewers.

Will look after you've had a chance to get to the linux bot errors.

[chasej, 2015-06-05 02:46:01]

Patchset #2 (id:20001) has been deleted

[chasej, 2015-06-05 04:18:54]

Patchset #2 (id:40001) has been deleted

[jkarlin, 2015-06-05 13:41:37]

lgtm, but I'm not an owner.

[jkarlin, 2015-06-05 13:44:25]

I'd suggest michaeln@ again for the module code since he reviewed the earlier
CL,  adamk for the web/ stuff and tkent@ for public/web/

[chasej, 2015-06-05 17:53:14]

chasej@chromium.org changed reviewers:
+ adamk@chromium.org, michaeln@chromium.org, tkent@chromium.org

[chasej, 2015-06-05 17:57:13]

Please take a look, as below.

tkent: public/web
adamk: web/
michaeln: modules/service_worker

[jkarlin, 2015-06-09 14:10:48]

On 2015/06/05 17:57:13, chasej wrote:
> Please take a look, as below.
> 
> tkent: public/web
> adamk: web/
> michaeln: modules/service_worker

tkent, adamk, michaeln, PTAL.

[michaeln, 2015-06-09 20:42:57]

modules/sw lgtm, looks like you're following a well worn cow path

https://codereview.chromium.org/1148293011/diff/80001/Source/web/ServiceWorke...
File Source/web/ServiceWorkerGlobalScopeProxy.cpp (right):

https://codereview.chromium.org/1148293011/diff/80001/Source/web/ServiceWorke...
Source/web/ServiceWorkerGlobalScopeProxy.cpp:170: // the event finished to allow
for cleanup/handling.
This comment probably isn't needed. Blink generally prefers fewer code comments
and invoking a completion callback when disabled probably isn't noteworthy
enough.

[tkent, 2015-06-09 23:49:36]

lgtm

[chasej, 2015-06-10 21:04:59]

adamk, PTAL.

I've added a patch to remove the unnecessary comment as suggested.

https://codereview.chromium.org/1148293011/diff/80001/Source/web/ServiceWorke...
File Source/web/ServiceWorkerGlobalScopeProxy.cpp (right):

https://codereview.chromium.org/1148293011/diff/80001/Source/web/ServiceWorke...
Source/web/ServiceWorkerGlobalScopeProxy.cpp:170: // the event finished to allow
for cleanup/handling.
On 2015/06/09 20:42:57, michaeln wrote:
> This comment probably isn't needed. Blink generally prefers fewer code
comments
> and invoking a completion callback when disabled probably isn't noteworthy
> enough.

Done.

[adamk, 2015-06-10 21:14:11]

tkent's approval should be enough, please let me know if it's not and we'll fix
up the owners file (not saying "l-g-t-m" to make sure you can submit without my
approval :)

[chasej, 2015-06-10 22:19:27]

The CQ bit was checked by chasej@chromium.org

[chasej, 2015-06-10 22:19:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkarlin@chromium.org, michaeln@chromium.org, tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1148293011/#ps100001
(title: "Remove unnecessary comment")

[commit-bot: I haz the power, 2015-06-10 22:19:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148293011/100001

[commit-bot: I haz the power, 2015-06-10 22:23:05]

Committed patchset #4 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196904