Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(30)

Issue 1148283011: Update programmatic scrolls on the RootFrameViewport. (Closed)

Created:
4 years, 11 months ago by bokan
Modified:
4 years, 11 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update programmatic smooth scrolls on the RootFrameViewport. Currently, the update occurs on the root FrameView so any programmatic smooth scrolls on the RootFrameViewport wont get updated. This patch causes the update to occur on the RootFrameViewport, which updates its own animations, then calls the root FrameView's update method. No test as smooth scrolls on RootFrameViewport aren't supported yet. When that's enabled, any tests on that will implicitly test that this works. BUG=434497 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M Source/core/frame/RootFrameViewport.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/RootFrameViewport.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
bokan
ptal.
4 years, 11 months ago (2015-06-03 21:27:27 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148283011/1
4 years, 11 months ago (2015-06-03 21:29:08 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64856) mac_blink_rel on ...
4 years, 11 months ago (2015-06-03 22:10:17 UTC) #6
Ian Vollick
On 2015/06/03 at 22:10:17, commit-bot wrote: > Dry run: Try jobs failed on following builders: ...
4 years, 11 months ago (2015-06-05 17:56:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148283011/1
4 years, 11 months ago (2015-06-05 17:58:15 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-06-05 20:27:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196603

Powered by Google App Engine
This is Rietveld 408576698