Source/modules/bluetooth/BluetoothGATTRemoteServer.h - Issue 1148283009: bluetooth: Remove deep copying of structs by using OwnPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/bluetooth/BluetoothGATTRemoteServer.h

Issue 1148283009: bluetooth: Remove deep copying of structs by using OwnPtr. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@bluetooth-get-primary-service-implementation

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/bluetooth/BluetoothDevice.cpp ('K') | « Source/modules/bluetooth/BluetoothDevice.cpp ('k') | Source/modules/bluetooth/BluetoothGATTRemoteServer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/bluetooth/BluetoothGATTRemoteServer.h

diff --git a/Source/modules/bluetooth/BluetoothGATTRemoteServer.h b/Source/modules/bluetooth/BluetoothGATTRemoteServer.h

index 7519b87a8092ba68e09f8b82a8ff20c9340030f6..e0f542c26e772be810d2b026f6ba6f447b50fa02 100644

--- a/Source/modules/bluetooth/BluetoothGATTRemoteServer.h

+++ b/Source/modules/bluetooth/BluetoothGATTRemoteServer.h

@@ -27,7 +27,7 @@ class BluetoothGATTRemoteServer final

, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

public:

- BluetoothGATTRemoteServer(const WebBluetoothGATTRemoteServer&);

+ BluetoothGATTRemoteServer(PassOwnPtr<WebBluetoothGATTRemoteServer>);

haraken 2015/06/04 00:40:16 Add explicit.

// Interface required by CallbackPromiseAdapter:

typedef WebBluetoothGATTRemoteServer WebType;

@@ -38,11 +38,11 @@ public:

DEFINE_INLINE_TRACE() { }

// IDL exposed interface:

- bool connected() { return m_webGATT.connected; }

+ bool connected() { return m_webGATT->connected; }

ScriptPromise getPrimaryService(ScriptState*, String serviceUUID);

private:

- WebBluetoothGATTRemoteServer m_webGATT;

+ OwnPtr<WebBluetoothGATTRemoteServer> m_webGATT;

};

} // namespace blink