Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1148283009: bluetooth: Remove deep copying of structs by using OwnPtr. (Closed)

Created:
4 years, 11 months ago by ortuno
Modified:
4 years, 11 months ago
CC:
blink-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@bluetooth-get-primary-service-implementation
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bluetooth: Remove deep copying of structs by using OwnPtr. By passing a PassOwnPtr to the constructor and keeping an OwnPtr as a member we avoid having deep copying strucs. BUG=496255 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196514

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -37 lines) Patch
M Source/modules/bluetooth/BluetoothDevice.h View 3 chunks +4 lines, -6 lines 1 comment Download
M Source/modules/bluetooth/BluetoothDevice.cpp View 3 chunks +11 lines, -17 lines 1 comment Download
M Source/modules/bluetooth/BluetoothGATTRemoteServer.h View 2 chunks +3 lines, -3 lines 1 comment Download
M Source/modules/bluetooth/BluetoothGATTRemoteServer.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/bluetooth/BluetoothGATTService.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/bluetooth/BluetoothGATTService.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ortuno
@jyasskin: PTAL
4 years, 11 months ago (2015-06-03 19:26:08 UTC) #2
Jeffrey Yasskin
lgtm https://codereview.chromium.org/1148283009/diff/1/Source/modules/bluetooth/BluetoothDevice.cpp File Source/modules/bluetooth/BluetoothDevice.cpp (right): https://codereview.chromium.org/1148283009/diff/1/Source/modules/bluetooth/BluetoothDevice.cpp#newcode21 Source/modules/bluetooth/BluetoothDevice.cpp:21: BluetoothDevice::BluetoothDevice(PassOwnPtr<WebBluetoothDevice> webDevice) It does work to take OwnPtr<> ...
4 years, 11 months ago (2015-06-03 23:39:22 UTC) #3
ortuno
@haraken: PTAL
4 years, 11 months ago (2015-06-03 23:41:51 UTC) #5
haraken
LGTM https://codereview.chromium.org/1148283009/diff/1/Source/modules/bluetooth/BluetoothDevice.h File Source/modules/bluetooth/BluetoothDevice.h (right): https://codereview.chromium.org/1148283009/diff/1/Source/modules/bluetooth/BluetoothDevice.h#newcode30 Source/modules/bluetooth/BluetoothDevice.h:30: BluetoothDevice(PassOwnPtr<WebBluetoothDevice>); Add explicit. https://codereview.chromium.org/1148283009/diff/1/Source/modules/bluetooth/BluetoothGATTRemoteServer.h File Source/modules/bluetooth/BluetoothGATTRemoteServer.h (right): https://codereview.chromium.org/1148283009/diff/1/Source/modules/bluetooth/BluetoothGATTRemoteServer.h#newcode30 ...
4 years, 11 months ago (2015-06-04 00:40:16 UTC) #6
scheib
LGTM
4 years, 11 months ago (2015-06-04 14:01:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148283009/1
4 years, 11 months ago (2015-06-04 16:26:36 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 17:04:21 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196514

Powered by Google App Engine
This is Rietveld 408576698