Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1148283002: Roll buildtools b73e5f0d7ac..dc487f429cb9 to roll GN 329298:330790 (Closed)

Created:
5 years, 7 months ago by Dirk Pranke
Modified:
5 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools b73e5f0d7ac..dc487f429cb9 to roll GN 329298:330790. List of changes: https://chromium.googlesource.com/chromium/buildtools/+log/b73e5f70d7ac..dc487f429cb9 commit dc487f429cb90cac92ec7a9cd9d49db13648064d Author: Dirk Pranke <dpranke@chromium.org>; Date: Wed May 20 14:44:08 2015 -0700 Roll GN 329298:330790 (c947c40710fe..9d04333fe102) List of changes in tools/gn: https://chromium.googlesource.com/chromium/src/+log/c947c40710fe..9d04333fe102/tools/gn This roll mostly pulls in two new GN features: 1) a new 'gn path' command for finding the dependencies linking two targets 2) the 'runtime_deps' option to 'gn desc', which will compute the list of files needed to for a target to run based on the dependencies and data files listed on the targets. If --runtime-deps-list-file is specified when 'gn gen' is run, GN will also write out the dependencies for the targets listed in the file to $target.runtime_deps files. TBR=brettw@chromium.org BUG=480053 R=brettw@chromium.org BUG=480053 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel Committed: https://crrev.com/f89d9b09d549eeebd330b1117f06ed8a02486e8b Cr-Commit-Position: refs/heads/master@{#330865}

Patch Set 1 #

Patch Set 2 : actual roll to dc487f429cb90cac92ec7a9cd9d49db13648064d #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148283002/20001
5 years, 7 months ago (2015-05-20 21:52:08 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-20 23:33:01 UTC) #4
brettw
lgtm
5 years, 7 months ago (2015-05-21 00:49:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148283002/20001
5 years, 7 months ago (2015-05-21 00:50:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 00:55:43 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 00:56:32 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f89d9b09d549eeebd330b1117f06ed8a02486e8b
Cr-Commit-Position: refs/heads/master@{#330865}

Powered by Google App Engine
This is Rietveld 408576698