Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(124)

Issue 1148263006: Remove setMainFrameScrollOffset method from WebViewImpl. (Closed)

Created:
4 years, 11 months ago by bokan
Modified:
4 years, 11 months ago
Reviewers:
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove setMainFrameScrollOffset method from WebViewImpl. Whoops, forgot to remove the declaration in r196421 BUG= TBR=skobes@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
bokan
TBR'ing since the change was LGTM'd in the noted revision.
4 years, 11 months ago (2015-06-03 21:18:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148263006/1
4 years, 11 months ago (2015-06-03 21:20:05 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65133)
4 years, 11 months ago (2015-06-03 22:22:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148263006/1
4 years, 11 months ago (2015-06-03 22:33:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65146)
4 years, 11 months ago (2015-06-03 23:17:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148263006/1
4 years, 11 months ago (2015-06-04 10:43:55 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 14:04:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196503

Powered by Google App Engine
This is Rietveld 408576698