components/cronet/android/java/build.xml - Issue 1148263004: [Cronet] Generate Javadoc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/cronet/android/java/build.xml

Issue 1148263004: [Cronet] Generate Javadoc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <project>

	2 <target name="doc" description="generate documentation">

	3 <javadoc destdir="${doc.dir}"

	4 windowtitle="Cronet API"

	5 nohelp="yes"

	6 noindex="yes"
	mef 2015/06/03 18:25:01 Not sure what noindex does, but it would make sens Not sure what noindex does, but it would make sense to have a TOC or something. xunjieli 2015/06/03 20:19:34 Done. Removed. Show quoted text On 2015/06/03 18:25:01, mef wrote: > Not sure what noindex does, but it would make sense to have a TOC or something. Done. Removed.
	7 notree="yes"

	8 nodeprecated="yes"

	9 >

	10 <fileset dir="${source.dir}" defaultexcludes="yes">

	11 <include name="*/.java"/>
	mef 2015/06/03 18:25:01 Should we generate javadoc just for interface file Should we generate javadoc just for interface files and not implementation? This would reduce noise / clutter. xunjieli 2015/06/03 20:19:34 Looking at the internal code base, our current emb Show quoted text On 2015/06/03 18:25:01, mef wrote: > Should we generate javadoc just for interface files and not implementation? This > would reduce noise / clutter. Looking at the internal code base, our current embedders are using the concrete ones directly (eg. CronetUrlRequestContext), so I think we should still need to keep them there. mef 2015/06/03 22:00:54 Sounds good, as long as only 'public' classes get Show quoted text On 2015/06/03 20:19:34, xunjieli wrote: > On 2015/06/03 18:25:01, mef wrote: > > Should we generate javadoc just for interface files and not implementation? > This > > would reduce noise / clutter. > > Looking at the internal code base, our current embedders are using the concrete > ones directly (eg. CronetUrlRequestContext), so I think we should still need to > keep them there. Sounds good, as long as only 'public' classes get javadoc'ed. Could you confirm that non-public classes are not excluded? xunjieli 2015/06/04 13:37:35 Confirmed that non-public classes are not included Show quoted text On 2015/06/03 22:00:54, mef wrote: > On 2015/06/03 20:19:34, xunjieli wrote: > > On 2015/06/03 18:25:01, mef wrote: > > > Should we generate javadoc just for interface files and not implementation? > > This > > > would reduce noise / clutter. > > > > Looking at the internal code base, our current embedders are using the > concrete > > ones directly (eg. CronetUrlRequestContext), so I think we should still need > to > > keep them there. > > Sounds good, as long as only 'public' classes get javadoc'ed. Could you confirm > that non-public classes are not excluded? Confirmed that non-public classes are not included :)
	12 <!-- exclude legacy API -->

	13 <exclude name="*/Chromium.java"/>

	14 <exclude name="*/ChunkedWritableByteChannel.java"/>

	15 <exclude name="*/HttpUrl.java"/>

	16 </fileset>

	17 </javadoc>

	18 </target>

	19 </project>

OLD	NEW

« no previous file with comments | « components/cronet.gypi ('k') | components/cronet/tools/generate_javadoc.py » ('j') | components/cronet/tools/generate_javadoc.py » ('J')