chromecast/media/cma/pipeline/audio_pipeline_impl.cc - Issue 1148253006: Chromecast: Use std::vector to pass video config in CMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/cma/pipeline/audio_pipeline_impl.cc

Issue 1148253006: Chromecast: Use std::vector to pass video config in CMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add more DCHECK Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/media/cma/filters/demuxer_stream_adapter_unittest.cc ('k') | chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc » ('j') | chromecast/media/cma/pipeline/video_pipeline_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/media/cma/pipeline/audio_pipeline_impl.cc

diff --git a/chromecast/media/cma/pipeline/audio_pipeline_impl.cc b/chromecast/media/cma/pipeline/audio_pipeline_impl.cc

index 82b56e25973ab5df2cf10edad30ddd43495bc444..d937f8a2bc8c49c12a0ae9e566668519451be008 100644

--- a/chromecast/media/cma/pipeline/audio_pipeline_impl.cc

+++ b/chromecast/media/cma/pipeline/audio_pipeline_impl.cc

@@ -109,6 +109,7 @@ void AudioPipelineImpl::Initialize(

if (frame_provider)

SetCodedFrameProvider(frame_provider.Pass());

+ DCHECK(audio_config.IsValidConfig());

if (!audio_device_->SetConfig(

DecoderConfigAdapter::ToCastAudioConfig(kPrimary, audio_config)) ||

!av_pipeline_impl_->Initialize()) {

@@ -127,6 +128,7 @@ void AudioPipelineImpl::OnUpdateConfig(

StreamId id,

const ::media::AudioDecoderConfig& audio_config,

const ::media::VideoDecoderConfig& video_config) {

+ DCHECK(!video_config.IsValidConfig());

if (audio_config.IsValidConfig()) {

CMALOG(kLogControl) << "AudioPipelineImpl::OnUpdateConfig id:" << id << " "

<< audio_config.AsHumanReadableString();