chromecast/media/cma/pipeline/audio_pipeline_impl.cc - Issue 1148253006: Chromecast: Use std::vector to pass video config in CMA

Unified Diff: chromecast/media/cma/pipeline/audio_pipeline_impl.cc

Issue 1148253006: Chromecast: Use std::vector to pass video config in CMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/media/cma/filters/cma_renderer.cc ('K') | « chromecast/media/cma/filters/demuxer_stream_adapter_unittest.cc ('k') | chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc » ('j') | chromecast/media/cma/pipeline/video_pipeline_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/media/cma/pipeline/audio_pipeline_impl.cc

diff --git a/chromecast/media/cma/pipeline/audio_pipeline_impl.cc b/chromecast/media/cma/pipeline/audio_pipeline_impl.cc

index 82b56e25973ab5df2cf10edad30ddd43495bc444..045281901ae340ad2896b3bcc8aa0a413e567116 100644

--- a/chromecast/media/cma/pipeline/audio_pipeline_impl.cc

+++ b/chromecast/media/cma/pipeline/audio_pipeline_impl.cc

@@ -127,6 +127,7 @@ void AudioPipelineImpl::OnUpdateConfig(

StreamId id,

const ::media::AudioDecoderConfig& audio_config,

const ::media::VideoDecoderConfig& video_config) {

+ DCHECK(!video_config.IsValidConfig());

gunsch 2015/06/04 17:03:42 Hm, is this actually safe? Do we only ever pass in

erickung1 2015/06/04 20:29:20 Yes. the config only comes with buffer if there is

gunsch 2015/06/05 00:17:12 What do you mean by "we should add this for check"

erickung1 2015/06/05 01:04:18 We should put DCHECK() here, because it's a bug an

if (audio_config.IsValidConfig()) {

CMALOG(kLogControl) << "AudioPipelineImpl::OnUpdateConfig id:" << id << " "

<< audio_config.AsHumanReadableString();