Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1148253003: Add LayoutRoot (Closed)

Created:
5 years, 7 months ago by eseidel
Modified:
5 years, 7 months ago
Reviewers:
Hixie
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make it possible to draw Text in the new window/document-less world I had to add back document.createText() since new Text() does not work in the new world yet. LayoutRoot is a new Dart-exposed class which holds the Frame and all associated machinery, sufficient to trigger a restyle and layout of the subtree. This is all kinda hacky and I'm sure likely to cause many crashes if folks call random methods on these disconnected trees. But this makes it at least possible to paint text for now and we can improve this in the coming days. This really should have Adam's review. It's hugely hacky but I'd like to negotiate out with him the timeline on which we should fix some of these hacks. TBR=abarth@chromium.org R=ianh@google.com

Patch Set 1 #

Patch Set 2 : Not ready for landing #

Patch Set 3 : Updated #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -21 lines) Patch
M sky/engine/core/core.gni View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/dom/Document.h View 4 chunks +6 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 5 chunks +10 lines, -8 lines 0 comments Download
M sky/engine/core/dom/Document.idl View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/frame/Frame.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/frame/Frame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/FrameHost.h View 2 chunks +4 lines, -0 lines 0 comments Download
M sky/engine/core/frame/FrameHost.cpp View 2 chunks +17 lines, -1 line 2 comments Download
M sky/engine/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 2 comments Download
M sky/engine/core/frame/LocalFrame.h View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 3 chunks +10 lines, -2 lines 0 comments Download
M sky/engine/core/frame/Settings.cpp View 1 chunk +2 lines, -1 line 0 comments Download
A sky/engine/core/painting/LayoutRoot.h View 1 chunk +62 lines, -0 lines 0 comments Download
A sky/engine/core/painting/LayoutRoot.cpp View 1 chunk +80 lines, -0 lines 0 comments Download
A sky/engine/core/painting/LayoutRoot.idl View 1 chunk +15 lines, -0 lines 1 comment Download
M sky/engine/core/rendering/InlineTextBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
A sky/examples/spinning_arabic.dart View 1 1 chunk +47 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
eseidel
5 years, 7 months ago (2015-05-26 17:50:44 UTC) #2
Hixie
lgtm This is great. We should figure out what the eventual API will look like ...
5 years, 7 months ago (2015-05-26 18:07:16 UTC) #3
eseidel
https://codereview.chromium.org/1148253003/diff/40001/sky/engine/core/frame/FrameHost.cpp File sky/engine/core/frame/FrameHost.cpp (right): https://codereview.chromium.org/1148253003/diff/40001/sky/engine/core/frame/FrameHost.cpp#newcode77 sky/engine/core/frame/FrameHost.cpp:77: // return m_page->deviceScaleFactor(); On 2015/05/26 at 18:07:16, Hixie wrote: ...
5 years, 7 months ago (2015-05-26 19:13:05 UTC) #4
eseidel
5 years, 7 months ago (2015-05-27 18:06:30 UTC) #5
Landed as 10892aee0f377cfd7431da9b834e65ca112858cc.

Powered by Google App Engine
This is Rietveld 408576698