Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1148253002: [Effen] Try to catch more misuse of fn by asserting that UINode nodes are only built when we're upd… (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Try to catch more misuse of fn by asserting that UINode nodes are only built when we're updatin the tree. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b42771eb255362cdd99464209e2fbc45b9309861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sky/sdk/lib/framework/fn.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 7 months ago (2015-05-20 19:45:59 UTC) #2
Hixie
5 years, 7 months ago (2015-05-20 19:47:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b42771eb255362cdd99464209e2fbc45b9309861 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698