components/plugins/renderer/loadable_plugin_placeholder.h - Issue 1148223004: Plugin Placeholders: Factor out common BindWebFrame method into base class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.h

Issue 1148223004: Plugin Placeholders: Factor out common BindWebFrame method into base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/plugins/renderer/loadable_plugin_placeholder.h

diff --git a/components/plugins/renderer/loadable_plugin_placeholder.h b/components/plugins/renderer/loadable_plugin_placeholder.h

index 7683ba7c6d8a081c1c7116859c449a061552a52c..e83dab94d5ed0e76fdc30bf522edadfef0479faa 100644

--- a/components/plugins/renderer/loadable_plugin_placeholder.h

+++ b/components/plugins/renderer/loadable_plugin_placeholder.h

@@ -73,9 +73,6 @@ class LoadablePluginPlaceholder : public PluginPlaceholder {

// Load the blocked plugin.

void LoadPlugin();

- // WebViewPlugin::Delegate (via PluginPlaceholder) method

- void BindWebFrame(blink::WebFrame* frame) override;

// gin::Wrappable method:

gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

v8::Isolate* isolate) override;

« no previous file with comments | « no previous file | components/plugins/renderer/loadable_plugin_placeholder.cc » ('j') | no next file with comments »