Fix crash when logging in with an open uber page.

Fix crash when logging in with an open uber page.

BUG=490056
Committed: https://crrev.com/72db076f6a9d87f7815a57f557939b8d605445ee
Cr-Commit-Position: refs/heads/master@{#330794}

[Dan Beam, 2015-05-20 18:37:35]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2015-05-20 18:40:02]

https://codereview.chromium.org/1148203002/diff/20001/chrome/browser/prefs/br...
File chrome/browser/prefs/browser_prefs.cc (right):

https://codereview.chromium.org/1148203002/diff/20001/chrome/browser/prefs/br...
chrome/browser/prefs/browser_prefs.cc:426: #if !defined(OS_ANDROID) &&
!defined(OS_IOS)
i think this might be functionally equivalent... but the EXTENSIONS +
!iOS/Android is throwing me off (isn't that redundant?)

https://codereview.chromium.org/1148203002/diff/20001/chrome/browser/prefs/br...
chrome/browser/prefs/browser_prefs.cc:517:
browser_sync::ForeignSessionHandler::RegisterProfilePrefs(registry);
registering here avoids accidental double registration from multiple handlers

https://codereview.chromium.org/1148203002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/foreign_session_handler.cc (left):

https://codereview.chromium.org/1148203002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/foreign_session_handler.cc:161: Init();
only called one place

https://codereview.chromium.org/1148203002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/foreign_session_handler.cc:192: base::ListValue
list_value;
not needed, declared too high.  just axed.

[Dan Beam, 2015-05-20 18:43:58]

dbeam@chromium.org changed reviewers:
+ thestig@chromium.org

[Dan Beam, 2015-05-20 18:45:23]

+thestig for chrome/browser/prefs/browser_prefs.cc

[Ken Rockot(use gerrit already), 2015-05-20 19:11:24]

lgtm

https://codereview.chromium.org/1148203002/diff/20001/chrome/browser/prefs/br...
File chrome/browser/prefs/browser_prefs.cc (right):

https://codereview.chromium.org/1148203002/diff/20001/chrome/browser/prefs/br...
chrome/browser/prefs/browser_prefs.cc:426: #if !defined(OS_ANDROID) &&
!defined(OS_IOS)
On 2015/05/20 18:40:02, Dan Beam wrote:
> i think this might be functionally equivalent... but the EXTENSIONS +
> !iOS/Android is throwing me off (isn't that redundant?)

Yeah, they're effectively equivalent today. This inner block probably predates
the existence of ENABLE_EXTENSIONS. You could probably remove it if you want.
Not a big deal IMO

[Lei Zhang, 2015-05-20 19:36:58]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-05-20 19:36:59]

lgtm

[commit-bot: I haz the power, 2015-05-20 19:37:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148203002/20001

[commit-bot: I haz the power, 2015-05-20 20:37:23]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-05-20 20:38:10]

Patchset 1 (id:??) landed as
https://crrev.com/72db076f6a9d87f7815a57f557939b8d605445ee
Cr-Commit-Position: refs/heads/master@{#330794}