chrome/browser/banners/app_banner_debug_log.h - Issue 1148163003: Allow only responsive websites to install as a web app on mobile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_debug_log.h

Issue 1148163003: Allow only responsive websites to install as a web app on mobile. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restoring a lost nullptr check Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/banners/app_banner_debug_log.h

diff --git a/chrome/browser/banners/app_banner_debug_log.h b/chrome/browser/banners/app_banner_debug_log.h

index dab2733bd2081284e4754b5a8b131cdecdcbf6c4..0e720fceabfbb2525f5c14a907ea0e619490a28b 100644

--- a/chrome/browser/banners/app_banner_debug_log.h

+++ b/chrome/browser/banners/app_banner_debug_log.h

@@ -27,6 +27,7 @@ extern const char kManifestMissingSuitableIcon[];

extern const char kNotServedFromSecureOrigin[];

extern const char kIgnoredNotSupportedOnAndroid[];

extern const char kIgnoredNoId[];

+extern const char kMetaViewportTagError[];

// Logs a message to the main console if a banner could not be shown

// and the engagement checks have been bypassed.

« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_debug_log.cc » ('j') | no next file with comments »