Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2632)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1148163003: Allow only responsive websites to install as a web app on mobile. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merging with latest master Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index f908db90547cf92c2b1b1796cdb15a9eaf3ebd00..44b2d581e6fd242e7ee8ff3c90b94b57fdd49330 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -123,6 +123,14 @@ class AppBannerDataFetcher
// metric being recorded.
void RecordDidShowBanner(const std::string& event_name);
+ // Returns whether the fetcher is active and web contents have not been
+ // closed.
+ bool CheckFetcherIsStillAlive(content::WebContents* web_contents);
+
+ virtual void HandleWebApp(content::WebContents* web_contents);
+
+ GURL validated_url_;
+
private:
// Callbacks for data retrieval.
void OnDidGetManifest(const content::Manifest& manifest);
@@ -139,10 +147,6 @@ class AppBannerDataFetcher
// Returns whether the banner should be shown.
bool CheckIfShouldShowBanner();
- // Returns whether the fetcher is active and web contents have not been
- // closed.
- bool CheckFetcherIsStillAlive(content::WebContents* web_contents);
-
// Returns whether the given Manifest is following the requirements to show
// a web app banner.
static bool IsManifestValidForWebApp(const content::Manifest& manifest,
@@ -156,7 +160,6 @@ class AppBannerDataFetcher
scoped_ptr<chrome::BitmapFetcher> bitmap_fetcher_;
scoped_ptr<SkBitmap> app_icon_;
- GURL validated_url_;
base::string16 app_title_;
content::Manifest web_app_data_;

Powered by Google App Engine
This is Rietveld 408576698