chrome/browser/banners/app_banner_manager.h - Issue 1148163003: Allow only responsive websites to install as a web app on mobile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 1148163003: Allow only responsive websites to install as a web app on mobile. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Preventing unintended method hiding Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/banners/app_banner_debug_log.cc ('K') | « chrome/browser/banners/app_banner_debug_log.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_manager.h

diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h

index a84be6053512a13a9e486103c99699e249c6a007..58491cb15eaee77e9210a6c9c7b6dcafa36283e5 100644

--- a/chrome/browser/banners/app_banner_manager.h

+++ b/chrome/browser/banners/app_banner_manager.h

@@ -44,6 +44,8 @@ class AppBannerManager : public content::WebContentsObserver,

const GURL& validated_url) override;

protected:

+ bool ValidateFrameHostAndOrigin(content::RenderFrameHost* render_frame_host,

+ const GURL& validated_url);

void ReplaceWebContents(content::WebContents* web_contents);

// Creates an AppBannerDataFetcher, which constructs an app banner.