Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: chrome/browser/banners/app_banner_debug_log.h

Issue 1148163003: Allow only responsive websites to install as a web app on mobile. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Preventing unintended method hiding Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_debug_log.h
diff --git a/chrome/browser/banners/app_banner_debug_log.h b/chrome/browser/banners/app_banner_debug_log.h
index dab2733bd2081284e4754b5a8b131cdecdcbf6c4..65aa43d0060646ce64ff85eae037329f494d464f 100644
--- a/chrome/browser/banners/app_banner_debug_log.h
+++ b/chrome/browser/banners/app_banner_debug_log.h
@@ -27,12 +27,22 @@ extern const char kManifestMissingSuitableIcon[];
extern const char kNotServedFromSecureOrigin[];
extern const char kIgnoredNotSupportedOnAndroid[];
extern const char kIgnoredNoId[];
+extern const char kAddMetaViewportTag[];
+extern const char kValidMetaViewportTagNotFound[];
+extern const char kMetaViewportTagContentsTooLong[];
+extern const char kMetaViewportTagNotResponsive[];
// Logs a message to the main console if a banner could not be shown
// and the engagement checks have been bypassed.
void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
const std::string& message);
+// Logs a message to the main console if a banner could not be shown due to a
+// missing or incorrect meta viewport tag on mobile
+// and the engagement checks have been bypassed.
+void OutputDeveloperMetaViewportErrorMessage(content::WebContents* web_contents,
+ const std::string& message);
+
// Logs a debugging message to the main console if the engagement checks have
// been bypassed.
void OutputDeveloperDebugMessage(content::WebContents* web_contents,

Powered by Google App Engine
This is Rietveld 408576698