Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1148163003: Allow only responsive websites to install as a web app on mobile. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Preventing unintended method hiding Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index fcab9129fac10eb3982b06782f49202b960a4c9e..39bc75da334eab6335b1236731b8feda69f6408a 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -62,7 +62,7 @@ class AppBannerDataFetcher
// Begins creating a banner for the URL being displayed by the Delegate's
// WebContents.
- void Start(const GURL& validated_url);
+ virtual void Start(const GURL& validated_url);
// Stops the pipeline when any asynchronous calls return.
void Cancel();
@@ -79,6 +79,10 @@ class AppBannerDataFetcher
// Returns whether or not the pipeline has been stopped.
bool is_active() { return is_active_; }
+ // Returns whether or not the requesting site is responsive. Used only on
+ // mobile.
+ bool is_responsive() { return is_responsive_; }
+
// Returns the URL that kicked off the banner data retrieval.
const GURL& validated_url() { return validated_url_; }
@@ -122,6 +126,14 @@ class AppBannerDataFetcher
// metric being recorded.
void RecordDidShowBanner(const std::string& event_name);
+ // Returns whether the fetcher is active and web contents have not been
+ // closed.
+ bool CheckFetcherIsStillAlive(content::WebContents* web_contents);
+
+ bool is_active_;
+ bool is_responsive_;
+ GURL validated_url_;
+
private:
// Callbacks for data retrieval.
void OnDidGetManifest(const content::Manifest& manifest);
@@ -138,10 +150,6 @@ class AppBannerDataFetcher
// Returns whether the banner should be shown.
bool CheckIfShouldShowBanner();
- // Returns whether the fetcher is active and web contents have not been
- // closed.
- bool CheckFetcherIsStillAlive(content::WebContents* web_contents);
-
// Returns whether the given Manifest is following the requirements to show
// a web app banner.
static bool IsManifestValidForWebApp(const content::Manifest& manifest,
@@ -150,12 +158,10 @@ class AppBannerDataFetcher
const int ideal_icon_size_;
const base::WeakPtr<Delegate> weak_delegate_;
ObserverList<Observer> observer_list_;
- bool is_active_;
int event_request_id_;
scoped_ptr<chrome::BitmapFetcher> bitmap_fetcher_;
scoped_ptr<SkBitmap> app_icon_;
- GURL validated_url_;
base::string16 app_title_;
content::Manifest web_app_data_;

Powered by Google App Engine
This is Rietveld 408576698