Allow only responsive websites to install as a web app on mobile.

chrome/browser/banners/app_banner_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_manager.h"
 
 #include "base/metrics/field_trial.h"
 #include "chrome/browser/banners/app_banner_data_fetcher.h"
 #include "chrome/browser/banners/app_banner_debug_log.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
@@ skipping 31 matching lines @@
       weak_factory_(this) {
 }
 
 AppBannerManager::~AppBannerManager() {
   CancelActiveFetcher();
 }
 
 void AppBannerManager::DidFinishLoad(
     content::RenderFrameHost* render_frame_host,
     const GURL& validated_url) {
-  if (render_frame_host->GetParent())
+  if (!ValidateFrameHostAndOrigin(render_frame_host, validated_url))

[benwells, 2015/06/11 01:54:24]

What is this change for?

[dominickn (DO NOT USE), 2015/06/11 03:32:12]

It was due to the former implementation of this feature. I'll unwind this
change.

     return;
 
-  if (data_fetcher_.get() && data_fetcher_->is_active() &&
-      URLsAreForTheSamePage(data_fetcher_->validated_url(), validated_url)) {
-    return;
-  }
-
-  // A secure origin is required to show banners, so exit early if we see the
-  // URL is invalid.
-  if (!content::IsOriginSecure(validated_url) &&
-      !gDisableSecureCheckForTesting) {
-    OutputDeveloperNotShownMessage(web_contents(), kNotServedFromSecureOrigin);
-    return;
-  }
-
   // Kick off the data retrieval pipeline.
   data_fetcher_ = CreateAppBannerDataFetcher(weak_factory_.GetWeakPtr(),
                                              ideal_icon_size_);
   data_fetcher_->Start(validated_url);
 }
 
 bool AppBannerManager::HandleNonWebApp(const std::string& platform,
                                        const GURL& url,
                                        const std::string& id) {
   return false;
 }
 
+bool AppBannerManager::ValidateFrameHostAndOrigin(
+    content::RenderFrameHost* render_frame_host,
+    const GURL& validated_url) {
+  if (render_frame_host->GetParent())
+    return false;
+
+  if (data_fetcher_.get() && data_fetcher_->is_active() &&
+      URLsAreForTheSamePage(data_fetcher_->validated_url(), validated_url)) {
+    return false;
+  }
+
+  // A secure origin is required to show banners, so exit early if we see the
+  // URL is invalid.
+  if (!content::IsOriginSecure(validated_url) &&
+      !gDisableSecureCheckForTesting) {
+    OutputDeveloperNotShownMessage(web_contents(), kNotServedFromSecureOrigin);
+    return false;
+  }
+  return true;
+}
+
 void AppBannerManager::ReplaceWebContents(content::WebContents* web_contents) {
   Observe(web_contents);
   if (data_fetcher_.get())
     data_fetcher_.get()->ReplaceWebContents(web_contents);
 }
 
 void AppBannerManager::CancelActiveFetcher() {
   if (data_fetcher_ != nullptr) {
     data_fetcher_->Cancel();
     data_fetcher_ = nullptr;
   }
 }
 
 bool AppBannerManager::IsFetcherActive() {
   return data_fetcher_ != nullptr && data_fetcher_->is_active();
 }
 
 void AppBannerManager::DisableSecureSchemeCheckForTesting() {
   gDisableSecureCheckForTesting = true;
 }
 
 bool AppBannerManager::IsEnabled() {
   return base::FieldTrialList::FindFullName("AppBanners") == "Enabled";
 }
 
 }  // namespace banners