Allow only responsive websites to install as a web app on mobile.

chrome/browser/banners/app_banner_data_fetcher.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_data_fetcher.h"
 
 #include "base/bind.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/banners/app_banner_debug_log.h"
@@ skipping 52 matching lines @@
 // static
 void AppBannerDataFetcher::SetTimeDeltaForTesting(int days) {
   gTimeDeltaForTesting = base::TimeDelta::FromDays(days);
 }
 
 AppBannerDataFetcher::AppBannerDataFetcher(
     content::WebContents* web_contents,
     base::WeakPtr<Delegate> delegate,
     int ideal_icon_size)
     : WebContentsObserver(web_contents),
+      is_active_(false),
+      is_responsive_(true),

[benwells, 2015/05/27 05:58:55]

I think this can be made cleaner. In particular we don't need the is_responsive_
field (which is kind of falsely set to true on desktop) and to have the Start
method overridden / called later.

Given we may want to check responsiveness differently depending native /
webbiness, maybe we should do it after that has been determined. That is, there
would be a new function called something like
'CheckResponsiveness(base::Callback... then)'. In the base fetcher this would
just call then, but in the android one in would do the meta tag checks etc.

[dominickn (DO NOT USE), 2015/06/05 07:42:59]

Done, but slightly differently to your suggestion.

       ideal_icon_size_(ideal_icon_size),
       weak_delegate_(delegate),
-      is_active_(false),
       event_request_id_(-1) {
 }
 
 void AppBannerDataFetcher::Start(const GURL& validated_url) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   content::WebContents* web_contents = GetWebContents();
   DCHECK(web_contents);
 
   is_active_ = true;
@@ skipping 166 matching lines @@
       if (weak_delegate_->HandleNonWebApp(platform, application.url, id))
         return;
     }
   }
 
   if (!IsManifestValidForWebApp(manifest, web_contents)) {
     Cancel();
     return;
   }
 
+  if (!is_responsive_) {
+    OutputDeveloperMetaViewportErrorMessage(web_contents,
+                                            kMetaViewportTagNotResponsive);
+    Cancel();
+    return;
+  }
+
   banners::TrackDisplayEvent(DISPLAY_EVENT_BANNER_REQUESTED);
 
   web_app_data_ = manifest;
   app_title_ = web_app_data_.name.string();
 
   // Check to see if there is a single service worker controlling this page
   // and the manifest's start url.
   Profile* profile =
       Profile::FromBrowserContext(web_contents->GetBrowserContext());
   content::StoragePartition* storage_partition =
@@ skipping 122 matching lines @@
     return false;
   }
   if (!DoesManifestContainRequiredIcon(manifest)) {
     OutputDeveloperNotShownMessage(web_contents, kManifestMissingSuitableIcon);
     return false;
   }
   return true;
 }
 
 }  // namespace banners