Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1148143002: Revert of Fix a crash when views::HWNDMessageHandler::HandleTouchMessage (Closed)

Created:
5 years, 7 months ago by lanwei
Modified:
5 years, 7 months ago
Reviewers:
sadrul, ananta
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix a crash when views::HWNDMessageHandler::HandleTouchMessage (patchset #3 id:80001 of https://codereview.chromium.org/1147583002/) Reason for revert: We reverted the CL which needs to be fixed by this one, so we need to revert it one as well. We will recommit it once we fully fix and test it. Original issue's description: > Fix a crash when views::HWNDMessageHandler::HandleTouchMessage. > > There is a crash when calling views::HWNDMessageHandler::HandleTouchMessage, > because there are missing touch presses. Remove the CHECK for missing touch press, > and ignore when this happens. > > BUG=316085, 488473 > > Committed: https://crrev.com/41065dad044cd3bbd3c9bcc24e59eeae27a6c6a9 > Cr-Commit-Position: refs/heads/master@{#330751} TBR=sadrul@chromium.org,ananta@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=316085, 488473 Committed: https://crrev.com/187b7d3b38f2a439b1a10d389d5a52f3460777a2 Cr-Commit-Position: refs/heads/master@{#330757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 2 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lanwei
Created Revert of Fix a crash when views::HWNDMessageHandler::HandleTouchMessage
5 years, 7 months ago (2015-05-20 17:19:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148143002/1
5 years, 7 months ago (2015-05-20 17:19:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 17:20:29 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 17:21:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/187b7d3b38f2a439b1a10d389d5a52f3460777a2
Cr-Commit-Position: refs/heads/master@{#330757}

Powered by Google App Engine
This is Rietveld 408576698