[turbofan] Fix variable liveness control structure creation.

[turbofan] Fix variable liveness control structure creation.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/d2ca18d8496598f12859595a5b2db55d59ce0745
Cr-Commit-Position: refs/heads/master@{#28536}

[Jarin, 2015-05-20 17:48:31]

Could you take a look, please?

[titzer, 2015-05-20 17:57:26]

titzer@chromium.org changed reviewers:
+ titzer@chromium.org

[titzer, 2015-05-20 17:57:27]

https://codereview.chromium.org/1148133002/diff/20001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1148133002/diff/20001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:738: DCHECK(!IsLivenessAnalysisEnabled() ||
IsMarkedAsUnreachable());
You could move the DCHECKS here into a helper function to reduce a bit of
redundancy.

[Jarin, 2015-05-20 19:35:07]

https://codereview.chromium.org/1148133002/diff/20001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1148133002/diff/20001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:738: DCHECK(!IsLivenessAnalysisEnabled() ||
IsMarkedAsUnreachable());
On 2015/05/20 17:57:26, titzer wrote:
> You could move the DCHECKS here into a helper function to reduce a bit of
> redundancy.

Done.

[Benedikt Meurer, 2015-05-21 05:01:44]

LGTM.

[titzer, 2015-05-21 08:26:05]

On 2015/05/21 05:01:44, Benedikt Meurer wrote:
> LGTM.

LGTM

[Jarin, 2015-05-21 09:33:38]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2015-05-21 09:33:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148133002/40001

[commit-bot: I haz the power, 2015-05-21 09:57:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-21 09:57:49]

Patchset 3 (id:??) landed as
https://crrev.com/d2ca18d8496598f12859595a5b2db55d59ce0745
Cr-Commit-Position: refs/heads/master@{#28536}