IDL compiler: [SetReference]

IDL compiler: [SetReference]

New extended attribute, Python side to:
Reland: Reland: Implement new Blink IDL attribute [SetReference]
https://codereview.chromium.org/26792002

* Needed minor parser changes b/c using arguments:
[SetReference(A a, B b)]
* Also some test refactoring due to conflicting extended attributes.

BUG=239771
BUG=307341
R=haraken, kouhei
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164045

[kouhei (in TOK), 2013-12-17 08:38:05]

lgtm

[haraken, 2013-12-17 09:13:08]

LGTM

https://codereview.chromium.org/114813006/diff/1/Source/bindings/templates/in...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/114813006/diff/1/Source/bindings/templates/in...
Source/bindings/templates/interface.cpp:266: v8::Local<v8::Object>
creationContext = v8::Local<v8::Object>::New(isolate, wrapper);

kouhei: Why do we need to create a new Local handle here? Can't we simply use
|wrapper| as |creationContext| ?

https://codereview.chromium.org/114813006/diff/1/Source/bindings/templates/in...
Source/bindings/templates/interface.cpp:278: if (Node* owner =
impl->{{check_reachable_method}}()) {

check_reachable_method => reachable_node_function ?

(I think you're using "function" for C++ side function names.)

[kouhei (in TOK), 2013-12-17 09:15:00]

https://codereview.chromium.org/114813006/diff/1/Source/bindings/templates/in...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/114813006/diff/1/Source/bindings/templates/in...
Source/bindings/templates/interface.cpp:266: v8::Local<v8::Object>
creationContext = v8::Local<v8::Object>::New(isolate, wrapper);
On 2013/12/17 09:13:09, haraken wrote:
> 
> kouhei: Why do we need to create a new Local handle here? Can't we simply use
> |wrapper| as |creationContext| ?

I don't remember if there was a specific reason. I'll try your suggestion later.

[Nils Barth (inactive), 2013-12-18 01:57:48]

https://codereview.chromium.org/114813006/diff/1/Source/bindings/templates/in...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/114813006/diff/1/Source/bindings/templates/in...
Source/bindings/templates/interface.cpp:278: if (Node* owner =
impl->{{check_reachable_method}}()) {
On 2013/12/17 09:13:09, haraken wrote:
> check_reachable_method => reachable_node_function ?
> 
> (I think you're using "function" for C++ side function names.)

Good point, fixed!

[commit-bot: I haz the power, 2013-12-18 01:58:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/114813006/20001

[commit-bot: I haz the power, 2013-12-18 01:59:44]

Change committed as 164045